Regression in test case testCodeSelectInHybrid1415Projects #1127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
requires 1 VM arg per line
eg. preserve the `m[]` in the AST in the following case, (despite the fact that it's invalid), since javac does. ```java int[] foo = new int[m[]]; ``` Signed-off-by: David Thompson <davthomp@redhat.com>
Skip in case we're running tests to remain compatible with JDT
…n count Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Javac sometimes add virtual nodes to the tree (usually with endPos == -1). Ignore then when computing diagnostic position.
Log instead
This reverts commit 13618d9 as upstream as applied similar/better change when merging Java 23 support
* Treat DCRawText as raw text (don't both splitting lines) * Some fixes in TagElement range correction
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
…ings is set to true Signed-off-by: Rob Stryker <stryker@redhat.com>
…r in parsing or resolution Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
…tion Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com> Add helpful comments in code, and add test annotations Signed-off-by: Rob Stryker <stryker@redhat.com> More annotations Signed-off-by: Rob Stryker <stryker@redhat.com> More test annotations Signed-off-by: Rob Stryker <stryker@redhat.com> Missing import Signed-off-by: Rob Stryker <stryker@redhat.com>
Signed-off-by: Rob Stryker <stryker@redhat.com>
For Blocks and Lambdas
* unused variables * unqualified access * switch from internal classes to api
This causes 6 regerssions because 'possible this escape' is now reported. Signed-off-by: David Thompson <davthomp@redhat.com>
- fix a bug related to ordering of tag names
- get `@param| ` completion to work as expected
- use `DOMCompletionUtil.findParent` instead of only checking the direct
parent when calculating the node to use as context for completion
(in the case of nodes within `Javadoc`)
- split out `MemberRef` and `MethodRef` to their own completion cases
- for now these are stubs
- move the logic for type completion for `@see` and `@link` under the
TagElement section, as it should be handled differently than the
"default completion":
- improve handling of qualified references
- for the time being, suggest nothing when completing a type from a
specific module.
i.e. `@see java.base/java.util.|` no longer gives any results.
Signed-off-by: David Thompson <davthomp@redhat.com>
Also needed but missed.
Note that there are two code paths: one through `MemberRef` and another through an `@link` or `@see` `TagElement`. This is because the AST conversion tests expect the following to be a `TextElement` instead of a `MemberRef`: ```java /** * @see MyClass# */ ``` (and also:) ```java /** * @see # */ ``` However, the completion tests expect completion for MyClass' members to work in this case. Fixes eclipse-jdt#1103 Signed-off-by: David Thompson <davthomp@redhat.com>
* Type parameters * Annotations * Relevance
* Support type restriction for SwitchCase * Support for QualifiedType * Fix CompletionContext.getExpectedTypesSignatures()
* Return more proposals * Do no repeat extra import in proposals
- Fixes for the relevance numbers for methods in javadoc - Suggest constructors (including the default constructor) in `@see` and `@link` - Do not show completion when completing parameter name in method reference in Javadoc - when referencing a method from Javadoc, and the cursor is in the method parameters, specifically right after a `(` or `,`, complete the entire method signature This should fix 37 test cases Signed-off-by: David Thompson <davthomp@redhat.com>
robstryker
force-pushed
the
dom-with-javac
branch
from
96f35d1 to
1901a3c
Compare
|
Rebased and merged. I added this in as part of the history rewrite, because it's better that way. Force pushed. Confirmed via history the cause and the solution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from commit 6e81fe6 - overly-aggressive string replacement.