-
Notifications
You must be signed in to change notification settings - Fork 399
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No reliable way to distinguish code actions on client side #686
Labels
Comments
See also microsoft/language-server-protocol#389 which is also dealing with same sort of concerns |
Now we need an lsp4j update to support those codeaction kinds |
Logged an issue: eclipse-lsp4j/lsp4j#194 |
yyoncho
added a commit
to yyoncho/lsp-java
that referenced
this issue
Jun 23, 2018
- temporary use action title until eclipse-jdtls/eclipse.jdt.ls#686 is fixed.
yyoncho
added a commit
to yyoncho/lsp-java
that referenced
this issue
Jun 23, 2018
- temporary use action title until eclipse-jdtls/eclipse.jdt.ls#686 is fixed.
yyoncho
added a commit
to yyoncho/lsp-java
that referenced
this issue
Jun 23, 2018
- temporary use action title until eclipse-jdtls/eclipse.jdt.ls#686 is fixed.
The code action kind was added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
All of the code actions have the same command name -
java.apply.workspaceEdit
and the only way to distinguish them is to usetitle
which is not reliable. This is inconvenient if the client wants to bind code action to a shortcut.The text was updated successfully, but these errors were encountered: