Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No reliable way to distinguish code actions on client side #686

Closed
yyoncho opened this issue Jun 8, 2018 · 5 comments
Closed

No reliable way to distinguish code actions on client side #686

yyoncho opened this issue Jun 8, 2018 · 5 comments

Comments

@yyoncho
Copy link
Contributor

yyoncho commented Jun 8, 2018

All of the code actions have the same command name - java.apply.workspaceEdit and the only way to distinguish them is to use title which is not reliable. This is inconvenient if the client wants to bind code action to a shortcut.

@gorkem
Copy link
Contributor

gorkem commented Jun 11, 2018

See also microsoft/language-server-protocol#389 which is also dealing with same sort of concerns

@fbricon
Copy link
Contributor

fbricon commented Jun 11, 2018

Now we need an lsp4j update to support those codeaction kinds

@yaohaizh
Copy link
Contributor

yaohaizh commented Jun 12, 2018

Logged an issue: eclipse-lsp4j/lsp4j#194

yyoncho added a commit to yyoncho/lsp-java that referenced this issue Jun 23, 2018
- temporary use action title until
  eclipse-jdtls/eclipse.jdt.ls#686 is fixed.
yyoncho added a commit to yyoncho/lsp-java that referenced this issue Jun 23, 2018
yyoncho added a commit to yyoncho/lsp-java that referenced this issue Jun 23, 2018
@yaohaizh
Copy link
Contributor

The code action kind was added.

@yyoncho
Copy link
Contributor Author

yyoncho commented Apr 17, 2019

@gorkem @fbricon how do I use kind to distinguish the action kinds given the fact that a lot of the code actions have the same kind "quickfix"? For example, I want to bind Add throws declaration to a shortcut.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants