Typing () returns wrong set of signatures (textDocument/signatureHelp) #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
Apr 29, 2019
| @@ -80,6 +88,37 @@ public SignatureHelp signatureHelp(TextDocumentPositionParams position, IProgres | |||
| return help; | |||
| } | |||
|
|
|||
| private boolean isValid(ICompilationUnit unit, int offset, IProgressMonitor monitor) { | |||
| CompilationUnit ast = CoreASTProvider.getInstance().getAST(unit, CoreASTProvider.WAIT_YES, monitor); | |||
There was a problem hiding this comment.
instead of traversing the whole document, couldn't we find the closest enclosing node instead?
There was a problem hiding this comment.
I have updated the PR.
| public boolean visit(MethodRef node) { | ||
| if (node.getStartPosition() <= offset && (node.getStartPosition() + node.getLength()) >= offset) { | ||
| valid[0] = true; | ||
| } |
There was a problem hiding this comment.
once we found something, we should stop visiting the AST
| @Override | ||
| public void endVisit(MethodInvocation node) { | ||
| if (node.getStartPosition() <= offset && (node.getStartPosition() + node.getLength()) >= offset) { | ||
| valid[0] = true; |
There was a problem hiding this comment.
will this method be called after visit(MethodRef) or they're really for 2 different node types?
There was a problem hiding this comment.
They are different node types.
org.eclipse.jdt.core.dom.MethodInvocation
Method invocation expression AST node type.
org.eclipse.jdt.core.dom.MethodRef
AST node for a method or constructor reference within a doc comment (Javadoc). The principal uses of these are in "@see" and "@link" tag elements, for references to method and constructor members.
I have added a new test.
There was a problem hiding this comment.
we don't need signature help in javadoc, or do we?
snjeza
force-pushed
the
issue-1009
branch
2 times, most recently
from
3a59f30 to
4450d9f
Compare
|
Signature help stops after the 1st parameter if the current method returns something: This doesn't happen without the PR |
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
fbricon
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1009
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com