-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support textDocument/selectionRange #1102
Conversation
Signed-off-by: Rome Li <rome.li@microsoft.com>
org.eclipse.jdt.ls.tests/projects/maven/salut/src/main/java/java/Foo4.java
Outdated
Show resolved
Hide resolved
errr... how do you test this in vscode? I don't see any |
The vsocode-languageclient needs to be updated in vscode-java project as well. See redhat-developer/vscode-java#976 |
Signed-off-by: Rome Li <rome.li@microsoft.com>
Signed-off-by: Rome Li <rome.li@microsoft.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Except for minor remarks, this seems to work pretty well. We should definitely be able to ship it in the next release.
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/SelectionRangeHandler.java
Outdated
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/SelectionRangeHandler.java
Outdated
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/SelectionRangeHandler.java
Outdated
Show resolved
Hide resolved
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/SelectionRangeHandler.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Rome Li <rome.li@microsoft.com>
Signed-off-by: Rome Li <rome.li@microsoft.com>
Thanks for your contribution @akaroml! Keep'em coming! |
Feels great coding! Thanks! |
Signed-off-by: Rome Li rome.li@microsoft.com
Fix #1100