Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicFileDetectorTest.testInclusions* fail randomly #1270

Merged
merged 1 commit into from
Nov 25, 2019

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Nov 14, 2019

Fixes #1262

The PR introduces the following changes:

  • javaImportExclusions uses LinkedList
  • the SnippetUtilsTest, ReorgQuickFixTest, AbstractProjectsManagerBasedTest tests restore the preferenceManager property

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

@snjeza
Copy link
Contributor Author

snjeza commented Nov 15, 2019

test this please

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@snjeza snjeza changed the title [WIP] BasicFileDetectorTest.testInclusions* fail randomly BasicFileDetectorTest.testInclusions* fail randomly Nov 18, 2019
@@ -357,7 +358,7 @@
private int parallelBuildsCount;

static {
JAVA_IMPORT_EXCLUSIONS_DEFAULT = new ArrayList<>();
JAVA_IMPORT_EXCLUSIONS_DEFAULT = new LinkedList<>();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See redhat-developer/vscode-java#1084 (comment)

The order is important.

@fbricon fbricon merged commit 5b7b97f into eclipse-jdtls:master Nov 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BasicFileDetectorTest.testInclusions* fail randomly
2 participants