Provide preference mapping for Java Execution Environments -> Runtimes #1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So on a Mac, JDT automatically picks up JDKs under /Library/Java/JavaVirtualMachines/. If I set my custom JavaSE-11 pointing to /Users/fbricon/.sdkman/candidates/java/11.0.5.hs-adpt, when a project is configured to use JavaSE-11, it points to the JDK from /Library/Java/JavaVirtualMachines/jdk-11.jdk/. Since we explicitly set the preference, it should use that |
We can set more runtimes. I will add the default property, as follows: |
|
what does default mean? default JavaSE-11 runtime? It should be unique anyways, from a user standpoint. Or default to the workbench? And what happens when someone copies/pastes another runtime and you end up with multiple defaults? |
only first will be set as default. The following is schema: |
|
I agree we need a default jdk (eg. to use with invisible projects), but this doesn't change the fact that any JDK I set in the preference should be used by default vs anything picked up by JDT automatically |
|
|
No I want JavaSE-11 to be the default JavaSE-11 environment. The names themselves should be limited by the list of supported execution environment in eclipse. That's what I meant in https://github.com/redhat-developer/vscode-java/pull/1207/files#r360133208 |
snjeza
changed the title
|
test this please |
snjeza
force-pushed
the
runtimes
branch
3 times, most recently
from
a9d6b34 to
1abdf44
Compare
snjeza
changed the title
|
@fbricon I have updated the PR. |
fbricon
requested changes
Dec 24, 2019
There was a problem hiding this comment.
When saving the same runtime settings multiple times (doing a dummy or unrelated change in vscode's settings.json for instance), the list of runtimes is updated even if nothing changed. https://github.com/eclipse/eclipse.jdt.ls/pull/1309/files#diff-99e23b70fb2b30eae67e36c0455fd82cR148 should be false
| } | ||
| } | ||
| } | ||
| if (changed) { |
There was a problem hiding this comment.
JavaLanguageServerPlugin.logInfo("JVM Runtimes changed, saving new configuration");
| if (compatibleVM.equals(vm)) { | ||
| if (!environment.isStrictlyCompatible(vm)) { | ||
| JavaLanguageServerPlugin.logInfo("Runtime at '" + vm.getInstallLocation().toString() + "' is not strictly compatible with the '" + name + "' environment"); | ||
| } |
There was a problem hiding this comment.
JavaLanguageServerPlugin.logInfo("Setting " + compatibleVM.getInstallLocation() + " as " + name + "' environment (id:" + compatibleVM.getId() + ")");
fbricon
reviewed
Dec 24, 2019
| JavaLanguageServerPlugin.logInfo("Invalid runtime: " + runtime); | ||
| } | ||
| } | ||
| } |
There was a problem hiding this comment.
should log which runtime is the default VM (as multiple ones can have default:true, the last one wins)
fbricon
reviewed
Dec 24, 2019
| if (runtime.isValid()) { | ||
| runtimes.add(runtime); | ||
| } else { | ||
| JavaLanguageServerPlugin.logInfo("Multiple runtime name:" + runtime); |
fbricon
reviewed
Dec 24, 2019
| JavaLanguageServerPlugin.logInfo("Multiple runtime name:" + runtime); | ||
| } | ||
| } else { | ||
| JavaLanguageServerPlugin.logInfo("Multiple runtime name:" + runtime); |
There was a problem hiding this comment.
Multiple runtimes with name:
|
@fbricon I have updated the PR. |
fbricon
requested changes
Jan 6, 2020
| IPath systemSourcePath = sourcePath != null ? sourcePath : lib.getSystemLibrarySourcePath(); | ||
| URL javadocLocation = javadocURL != null ? javadocURL : lib.getJavadocLocation(); | ||
| LibraryLocation newLib = new LibraryLocation(lib.getSystemLibraryPath(), systemSourcePath, lib.getPackageRootPath(), javadocLocation, lib.getIndexLocation(), lib.getExternalAnnotationsPath()); | ||
| libChanged = !newLib.equals(lib); |
There was a problem hiding this comment.
libChanged = libChanged || !newLib.equals(lib);
|
Once again, if the runtimes didn't change, they're still reset on every didchangeconfiguration request: |
|
@fbricon I have updated the PR. |
|
test this please |
|
Related issue - #1317 |
Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
|
Thanks @snjeza! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1307
Requires redhat-developer/vscode-java#1207
Signed-off-by: Snjezana Peco snjezana.peco@redhat.com