Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update buildship to 3.1.4.v20200211-2258-s #1355

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

snjeza
Copy link
Contributor

@snjeza snjeza commented Feb 18, 2020

Fixes #1354 and eclipse-che/che#16051

This PR can be tested in the following way:

git clone https://github.com/che-samples/console-java-simple
cd console-java-simple
rm -rf .classpath .settings/ .project bin/  ~/.gradle/ .gradle/
code .

Signed-off-by: Snjezana Peco snjezana.peco@redhat.com

Signed-off-by: Snjezana Peco <snjezana.peco@redhat.com>
@snjeza snjeza requested review from gorkem and fbricon February 18, 2020 18:36
@fbricon
Copy link
Contributor

fbricon commented Feb 18, 2020

I tried to check the build would fail before applying your fix but it still works, after following the steps you wrote

@snjeza
Copy link
Contributor Author

snjeza commented Feb 18, 2020

Can you point to a specific commit in buildship that'd fix this issue?

eclipse-buildship/buildship@af18df1#diff-a8d2e7a6f3a2bbbef9dcda6896c934acL1

@eclipse-jdtls eclipse-jdtls deleted a comment from fbricon Feb 18, 2020
@snjeza
Copy link
Contributor Author

snjeza commented Feb 18, 2020

I tried to check the build would fail before applying your fix but it still works, after following the steps you wrote

Buildship 3.1.3.v20191107-2249-s uses the 6.0-20191016123526+0000 version of gradle that doesn't exist anymore.
Buildship 3.1.4.v20200211-2258-s uses the 6.0 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update buildship to 3.1.4
2 participants