-
Notifications
You must be signed in to change notification settings - Fork 409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add changelog for 0.67.0 #1631
Add changelog for 0.67.0 #1631
Conversation
Now that VS Code 1.52 has been released, you could consider merging #1608, for redhat-developer/vscode-java#1713. If that's merged you should probably also declare a dependency on VS Code 1.52 in vscode-java. I'll let you decide whether or not to merge it now, it's probably fine to wait until next release as well. |
Not really the place to talk about vscode versions, but vscode-java needs to run in Eclipse Their/Che which is a few compatible versions behind. |
Right, I forgot about that. But the deprecation of I'm not too familiar with Che or Theia, but judging from eclipse-theia/theia#8593 and eclipse-che/che-theia#908 it seems like the semantic tokens API was added to Che and Theia without any kind of scope mapping between semantic tokens and TextMate scopes. If this is the case then there wouldn't really be a reason that I can think of why #1608 would break anything in Che or Theia, apart from any themes using the old Of course, I could be wrong, seeing as I don't know much about the Che or Theia codebase, so if you need more time to review this that's fine too. But |
Let me clarify the whole story about the semantic token. Changes in LSP 3.16 (stable now)
JDT.LS, PR #1608
Clients to add scope mappings for the new type
Themes to add support for As it's part of the LSP 3.16 spec, we can merge it later when we udpate LSP to 3.16 and clients are ready for it. |
@rgrunber I propose to update the date to Dec. 17th so as to give time buffer for testing. One additional change I would like is #1617 (Gradle Project hasn't been updated properly). There are still some unresolved comments and I hope to catch this release. If not, it's ok to put it in the next release. |
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
Signed-off-by: Roland Grunberg rgrunber@redhat.com
@fbricon , @testforstephen
Let me know if there's any additonal changes we're waiting on.