Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog for 0.67.0 #1631

Merged
merged 1 commit into from
Dec 17, 2020
Merged

Conversation

rgrunber
Copy link
Contributor

Signed-off-by: Roland Grunberg rgrunber@redhat.com

@fbricon , @testforstephen

Let me know if there's any additonal changes we're waiting on.

@0dinD
Copy link
Contributor

0dinD commented Dec 15, 2020

Now that VS Code 1.52 has been released, you could consider merging #1608, for redhat-developer/vscode-java#1713. If that's merged you should probably also declare a dependency on VS Code 1.52 in vscode-java. I'll let you decide whether or not to merge it now, it's probably fine to wait until next release as well.

@fbricon
Copy link
Contributor

fbricon commented Dec 15, 2020

Not really the place to talk about vscode versions, but vscode-java needs to run in Eclipse Their/Che which is a few compatible versions behind.

@0dinD
Copy link
Contributor

0dinD commented Dec 15, 2020

Right, I forgot about that. But the deprecation of member /function doesn't really affect much, apart from the fact that themes using it will need to switch to method. The only reason why I wanted to wait for VS Code 1.52 is because it ensures correct mapping from semantic tokens to TextMate scopes, see this change in tokenClassificationRegistry.ts.

I'm not too familiar with Che or Theia, but judging from eclipse-theia/theia#8593 and eclipse-che/che-theia#908 it seems like the semantic tokens API was added to Che and Theia without any kind of scope mapping between semantic tokens and TextMate scopes. If this is the case then there wouldn't really be a reason that I can think of why #1608 would break anything in Che or Theia, apart from any themes using the old function semantic token (if they exist).

Of course, I could be wrong, seeing as I don't know much about the Che or Theia codebase, so if you need more time to review this that's fine too. But member is deprecated, and we haven't even switched to that from using function (which is even more "wrong"), so we should probably try to merge #1608 next update if not this one.

@Eskibear
Copy link
Contributor

Let me clarify the whole story about the semantic token.

Changes in LSP 3.16 (stable now)

  • [done] deprecate member (which has never been used in JDT.LS before)
  • [done] add method (requires clients to add proper TextMate scope mappings)
  • [PS] The function type used by jdtls is not deprecated, so it's not breaking anything now.

JDT.LS, PR #1608

  • [pending] to replace token function with method.

Clients to add scope mappings for the new type method

  • [ready] VS Code has done that in v1.52
  • [???] Che/Theia

Themes to add support for method, but still keep supporting function.

As it's part of the LSP 3.16 spec, we can merge it later when we udpate LSP to 3.16 and clients are ready for it.

@testforstephen
Copy link
Contributor

@rgrunber I propose to update the date to Dec. 17th so as to give time buffer for testing.

One additional change I would like is #1617 (Gradle Project hasn't been updated properly). There are still some unresolved comments and I hope to catch this release. If not, it's ok to put it in the next release.

CHANGELOG.md Outdated Show resolved Hide resolved
Signed-off-by: Roland Grunberg <rgrunber@redhat.com>
@testforstephen testforstephen merged commit 5959699 into eclipse-jdtls:master Dec 17, 2020
@rgrunber rgrunber deleted the cl-0.67.0 branch December 17, 2020 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants