Return completionItem documentation as plain text #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gorkem
reviewed
May 26, 2017
| import org.junit.Test; | ||
|
|
||
| /** | ||
| * Tests Javadoc to Markdown conversion |
There was a problem hiding this comment.
Change markdown to plain text?
| @@ -0,0 +1,114 @@ | |||
| /** | |||
| * Copyright © 2009-2017, Jonathan Hedley <jonathan@hedley.net> | |||
There was a problem hiding this comment.
Are we able to add this file without a CQ?
There was a problem hiding this comment.
I wasn't expecting to get away with it. We'll need to CQ JSoup anyway (dependency of Remark)
There was a problem hiding this comment.
There was a problem hiding this comment.
we're approved to check in
fbricon
force-pushed
the
plaintext-descriptions
branch
from
877ac49 to
8a601b3
Compare
fbricon
force-pushed
the
plaintext-descriptions
branch
2 times, most recently
from
7d748c7 to
1ed6853
Compare
fbricon
force-pushed
the
plaintext-descriptions
branch
from
1ed6853 to
e8df70f
Compare
Fixes redhat-developer/vscode-java#215 Signed-off-by: Fred Bricon <fbricon@gmail.com>
fbricon
force-pushed
the
plaintext-descriptions
branch
from
e8df70f to
a522ae1
Compare
gorkem
approved these changes
Jul 24, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#215
Signed-off-by: Fred Bricon fbricon@gmail.com