Support for Helidon framework

[rohanKanojia]

Description

Create Generator and Enricher support for Helidon framework

Generator should detect Helidon Maven Plugin. I couldn't find any equivalent gradle plugin in the repository.

• Implement HelidonGenerator in a new module jkube-kit-helidon Add HelidonGenerator to add opinionated container image for Helidon applications #1714
• Implement HelidonHealthCheckEnricher in a new module jkube-kit-helidon Add HelidonHealthCheckEnricher to add Kubernetes health checks for Helidon applications #1713
• Automatic port detection from Helidon configuration property files fix (jkube-kit-helidon) : HelidonHealthCheckEnricher should extract ports from properties #2235

[rohanKanojia]

Shall we close this?

[manusa]

Is it complete?

[rohanKanojia]

Yes, we have added generator, enricher, docs and quick starts

[manusa]

Then, if Automatic port detection from Helidon configuration property files. is also covered, check it out and then close the issue.

[rohanKanojia]

Are we talking about HelidonGenerator here or both HelidonGenrator + HelidonHealthCheckEnricher?

I see that HelidonGenerator does pick up port from application.properties/application.yaml while building container image. We also seem to have a test to verify it:
https://github.com/eclipse/jkube/blob/47c94d8a758949e0195e811d514427347cb00504/jkube-kit/jkube-kit-helidon/src/test/java/org/eclipse/jkube/helidon/generator/HelidonGeneratorExposedPortsTest.java#L89-L104

However, I don't see HelidonHealthCheckEnricher picking up port from configuration files. If we change port in configuration files, we also need to provide enricher configuration to override default port for health checks. I also see QuarkusHealthCheckEnricher is suffering from same issue.

[manusa]

However, I don't see HelidonHealthCheckEnricher picking up port from configuration files. If we change port in configuration files, we also need to provide enricher configuration to override default port for health checks. I also see QuarkusHealthCheckEnricher is suffering from same issue.

That looks like a bug, open a new issue so we can take care of this for Quarkus.

For Helidon, since it hasn't been released yet, we can do it in scope of this issue.
So I guess that should be the final change required.