schema validation warnings during mvn oc:resource and gradle k8sResource

[sockejr]

Describe the bug

During mvn builds in the goal oc:resource the following warnings are displayed:
Unknown keyword $module - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword Unknown keyword existingJavaType - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword Unknown keyword javaOmitEmpty - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword
This seems to be related to the schema validation, see discussion here:
#1932

Eclipse JKube version

other (please specify in additional context)

Component

OpenShift Maven Plugin

Apache Maven version

3.8.3

Gradle version

7.4.2

Steps to reproduce

in a project just run oc:resource
in a gradle project run k8sResource
see quickstart examples

Expected behavior

no schema validations are shown for keywords $module, existingjavaType, javaOmitEmpty

Runtime

OpenShift

Kubernetes API Server version

other (please specify in additional context)

Environment

Windows

Eclipse JKube Logs

from quickstart examples:$ ./gradlew k8sResource -Djkube.domain=$(minikube ip).nip.io
> Task :k8sResource
k8s: Running generator webapp
k8s: webapp: Using quay.io/jkube/jkube-jetty9:0.0.16 as base image for webapp
k8s: Using resource templates from /home/sunix/github/eclipse/jkube/quickstarts/gradle/webapp-jetty/src/main/jkube
k8s: jkube-controller: Adding a default Deployment
k8s: jkube-service: Adding a default service 'webapp-jetty' with ports [8080]
k8s: jkube-service-discovery: Using first mentioned service port '8080' 
k8s: jkube-revision-history: Adding revision history limit to 2
k8s: validating /home/sunix/github/eclipse/jkube/quickstarts/gradle/webapp-jetty/build/classes/java/main/META-INF/jkube/kubernetes/webapp-jetty-deployment.yml resource
Unknown keyword $module - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword
Unknown keyword existingJavaType - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword
Unknown keyword javaOmitEmpty - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword
k8s: validating /home/sunix/github/eclipse/jkube/quickstarts/gradle/webapp-jetty/build/classes/java/main/META-INF/jkube/kubernetes/webapp-jetty-service.yml resource
k8s: validating /home/sunix/github/eclipse/jkube/quickstarts/gradle/webapp-jetty/build/classes/java/main/META-INF/jkube/kubernetes/webapp-jetty-ingress.yml resource


from mvn oc:resource
Unknown keyword $module - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword Unknown keyword existingJavaType - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword Unknown keyword javaOmitEmpty - you should define your own Meta Schema. If the keyword is irrelevant for validation, just use a NonValidationKeyword

Sample Reproducer Project

https://github.com/eclipse/jkube/tree/master/quickstarts/maven/webapp-jetty

Additional context

this is happening for maven and gradle
this is happening when running oc:resource task, k8sResource task possibly (not checked) when running k8s:resource and ocResource.
according to discussion this also is happening for a long time
#1932

[rohanKanojia]

looks like it's talking about these keywords in the validation schema:

{
  "$module": "coordination"

This is just a meta field for the Kubernetes model generator module that generated the schema (e.g. kubernetes-model-apps, kubernetes-model-certificates, etc.)

I think we should just add NonValidationKeyword for these in ResourceValidator:

https://github.com/eclipse/jkube/blob/174d1897655b8af31637d79728169768d2cf8004/jkube-kit/common/src/main/java/org/eclipse/jkube/kit/common/util/validator/ResourceValidator.java#L162-L164

[manusa]

I think we should just add NonValidationKeyword for these in ResourceValidator:

Please, go ahead