-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
oc:build or k8s:build should warn the user that he may have forgotten to run a build or package #2070
Comments
This looks related to #1328 . There fix was done only in WebAppGenerator |
Hello I am beginner interested in contributing to this project .Are there beginner issues for one to try? |
@rohanKanojia @sunix even though this issue is related to #1328, we can't use the same approach because in #1328 we could simply check if the final output artefact was null ( JKubeProjectUtil.getFinalOutputArtifact(getProject()) ), but here the artefact would be already present as the user ran mvn package once already. I think we can use execution.getLifecyclePhase() in our Mojo to check this. We can then warn the user that they forgot to run mvn package... What do you think ? |
I haven't checked code but I think we need to make changes to all framework generators for this or maybe modify it's parent JavaExecGenerator Do you want to work on this issue? |
Yes I want to work on it |
Component
None
Is your enhancement related to a problem? Please describe
Context: User using an openshift cluster to deploy his development app.
mvn package oc:build oc:resource oc:apply
to deploy the applicationmvn oc:build oc:resource oc:apply
to deploy the app (missingpackage
)Describe the solution you'd like
If the user forgets about running
mvn package
prior tooc:build
, JKube should notify the user that he may have forgotten to runmvn package
.Subtasks
The text was updated successfully, but these errors were encountered: