Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Support for Chart.yaml fragments #2092

Closed
manusa opened this issue Mar 21, 2023 · 4 comments · Fixed by #2149
Closed

Helm: Support for Chart.yaml fragments #2092

manusa opened this issue Mar 21, 2023 · 4 comments · Fixed by #2149
Assignees
Labels
component/helm ⎈ enhancement New feature or request
Milestone

Comments

@manusa
Copy link
Member

manusa commented Mar 21, 2023

As a user I would like to provide a fragment for my JKube-generated Chart.yaml file. The contents of this fragment file should be merged with the final Chart.yaml after it has been generated, overriding any matching values.

Similar to #2112

Relates to:

@manusa manusa added enhancement New feature or request component/helm ⎈ labels Mar 21, 2023
@rohanKanojia rohanKanojia self-assigned this Apr 28, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Apr 28, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 2, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 3, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 3, 2023
@rohanKanojia
Copy link
Member

I couldn't find a direct mapping of Chart.yaml object in Kustomize model.

However, I was able to find a struct in helm repository : Metadata.go

rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 3, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 3, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 4, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 5, 2023
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue May 5, 2023
manusa pushed a commit to rohanKanojia/jkube that referenced this issue Jun 12, 2023
@manusa manusa added this to the 1.13.0 milestone Jun 12, 2023
manusa pushed a commit that referenced this issue Jun 12, 2023
Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@DominikBasnerSotec
Copy link
Contributor

@manusa @rohanKanojia Is it possible to get more information on this? I havent found kustomize in the doc, how do I use it?

@manusa
Copy link
Member Author

manusa commented Dec 14, 2023

Hey Dominik,
The issue had some internal relation with Kustomize during its inception because some of the types are now exposed through the Fabric8 Kubernetes Client model. However, this is completely unrelated now.

This feature allows you to add a chart.helm.yaml file to the src/main/jkube directory. JKube will gather the fields declared in this file and merge them with the ones JKube generates to create a final Chart.yaml file. You can check the following integration test project for more details: https://github.com/eclipse/jkube/tree/ed628ab7274088a66143d9c040bd6c862a531dd4/gradle-plugin/it/src/it/helm-fragment/src/main/jkube

@DominikBasnerSotec
Copy link
Contributor

Thx, will give it a try

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/helm ⎈ enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants