-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
k8s:build
fails to build image when image tag contains +
#2301
Comments
17 tasks
rohanKanojia
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 27, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
manusa
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 31, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
manusa
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Jul 31, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
rohanKanojia
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Aug 3, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
rohanKanojia
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Aug 7, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
rohanKanojia
pushed a commit
to rohanKanojia/jkube
that referenced
this issue
Aug 22, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
manusa
pushed a commit
that referenced
this issue
Aug 22, 2023
Signed-off-by: Christian Mäder <christian.maeder@nxt.engineering>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
originally posted by @cimnine in #1859
If we configure Kubernetes Maven Plugin to use image name like this:
k8s:build
fails with the following error saying image name is invalid:The given version is a valid SemVer version, however, it's not a valid image tag name. We should replace
+
character with some other character to handle this scenario.Eclipse JKube version
1.13.1
Component
Kubernetes Maven Plugin
Apache Maven version
other (please specify in additional context)
Gradle version
None
Steps to reproduce
Change image name generated by jkube to
%a:4.3.3-SNAPSHOT+st1666023054591-b24-7ca68455
using propertyjkube.generator.name
Expected behavior
k8s:build
should handle+
tag by replacing it with some other docker compatible tokenRuntime
Kubernetes (vanilla)
Kubernetes API Server version
1.25.3
Environment
Linux
Eclipse JKube Logs
Sample Reproducer Project
No response
Additional context
No response
The text was updated successfully, but these errors were encountered: