Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

k8s:push/k8sPush should work with buildpacks build strategy #2464

Closed
rohanKanojia opened this issue Nov 21, 2023 · 0 comments · Fixed by #2627
Closed

k8s:push/k8sPush should work with buildpacks build strategy #2464

rohanKanojia opened this issue Nov 21, 2023 · 0 comments · Fixed by #2627
Assignees
@rohanKanojia
Milestone
1.16.0

Comments

@rohanKanojia
Copy link
Member

rohanKanojia commented Nov 21, 2023 •
edited
Loading

Component

JKube Kit

Task description

Description

Related to #439

As a user building container images leveraging buildpacks with JKube, I want to push the image built using buildpacks, so that image is pushed to specified container registry using k8s:push/k8sPush goal/task

Expected Behavior

k8s:push should be able to push image created using k8s:build with buildpacks build strategy

Acceptance Criteria

Given:

  • User has performed k8s:build / k8sBuild of application leveraging buildpacks build strategy jkube.build.strategy=buildpacks.
  • User has configured image name correctly as per registry.

When: User performs k8s:push to push image to specified registry

Then: k8s:push works in buildpacks build strategy
@rohanKanojia rohanKanojia mentioned this issue Nov 21, 2023
Closed
3 tasks
@sunix sunix mentioned this issue Dec 7, 2023
Closed
6 tasks
@rohanKanojia rohanKanojia self-assigned this Feb 6, 2024
rohanKanojia added a commit to rohanKanojia/jkube that referenced this issue Feb 6, 2024
@rohanKanojia
fix (jkube-kit/config) : k8s:push / k8sPush should work with `bui…
faafac6 
…ldpacks` build strategy (eclipse-jkube#2464)

Delegate push image to RegistryService like we do in DockerBuildService

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
@rohanKanojia rohanKanojia mentioned this issue Feb 6, 2024
Merged
17 tasks
@manusa manusa added this to the 1.16.0 milestone Feb 7, 2024
manusa pushed a commit that referenced this issue Feb 7, 2024
@rohanKanojia @manusa
fix (jkube-kit/config) : k8s:push / k8sPush should work with `bui…
5006149 
…ldpacks` build strategy (#2464)

Delegate push image to RegistryService like we do in DockerBuildService

Signed-off-by: Rohan Kumar <rohaan@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanKanojia rohanKanojia

Labels
None yet
Projects
None yet
Milestone
1.16.0
2 participants
@manusa @rohanKanojia