Initial support for Gitpod (#1946) #1949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1949 (2023-08-24T08:14:46Z) ⚙️ JKube E2E Tests (5948470419)
|
Codecov Report
@@ Coverage Diff @@
## master #1949 +/- ##
============================================
+ Coverage 59.36% 60.74% +1.38%
- Complexity 4586 4725 +139
============================================
Files 500 514 +14
Lines 21211 21262 +51
Branches 2830 2806 -24
============================================
+ Hits 12591 12915 +324
+ Misses 7370 7124 -246
+ Partials 1250 1223 -27
... and 39 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
anurag-rajawat
force-pushed
the
gitpod
branch
from
6a830f6
to
8da6852
Compare
|
I think it would be nice to have some alignment with the tasks @sunix proposed in the equivalent |
anurag-rajawat
force-pushed
the
gitpod
branch
from
020f960
to
8da6852
Compare
|
For the tasks, these are the ones I am using: https://github.com/eclipse/jkube/blob/master/devfile.yaml#L100-L231 The |
|
@manusa and @sunix as per Gitpod docs there are three types of tasks:
In our case |
|
We can define the other tasks as "commands" but it is up to you. |
anurag-rajawat
force-pushed
the
gitpod
branch
4 times, most recently
from
07d48d2
to
1a7f226
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
anurag-rajawat
force-pushed
the
gitpod
branch
from
1a7f226
to
f867837
Compare
I also like it and I tried the |
I got a reply from the gitpod community and they gave a reference to https://www.gitpod.io/docs/introduction/learn-gitpod/gitpod-yaml and there I didn't find anything which can help us to add predefined commands. |
manusa
approved these changes
Jan 23, 2023
rohanKanojia
approved these changes
Jan 25, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
sunix
approved these changes
Jul 4, 2023
|
@anurag-rajawat we can merge this one if it is still good for you |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@sunix yes it will be good for contributors and I've updated contribution guidelines in eclipse-jkube/jkube-website#69 |
|
@anurag-rajawat : Could you please rebase your PR against master (hopefully one last time 🤞 ) . Let's get this merged within this week. |
Signed-off-by: Anurag Rajawat <anuragsinghrajawat22@gmail.com>
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1946
To get a preview of this click here
Type of change
test, version modification, documentation, etc.)
Checklist