-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc (jkube-kit/doc) : Documentation for Controller + InitContainer configuration (#1316) #1970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #1970 (2023-02-15T10:10:19Z) ⚙️ JKube E2E Tests (4164864880)
|
17 tasks
rohanKanojia
changed the title
doc (jkube-kit/doc) :
doc (jkube-kit/doc) : Documentation for Controller + InitContainer configuration (#1316)
Dec 20, 2022
Kudos, SonarCloud Quality Gate passed! |
Codecov Report
@@ Coverage Diff @@
## master #1970 +/- ##
============================================
+ Coverage 55.56% 55.58% +0.02%
- Complexity 4268 4271 +3
============================================
Files 481 481
Lines 21182 21182
Branches 2837 2837
============================================
+ Hits 11769 11775 +6
+ Misses 8204 8201 -3
+ Partials 1209 1206 -3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
rohanKanojia
force-pushed
the
doc/issue1316
branch
from
January 30, 2023 15:25
ff363f2
to
68d6adb
Compare
rohanKanojia
force-pushed
the
doc/issue1316
branch
from
February 13, 2023 14:28
68d6adb
to
0ebea0e
Compare
…ntation to JKube Kit Docs Documentation for things like labels/annotations, controller, ServiceAccount, Ingress, volumes etc. were duplicated in both maven and gradle plugins. Create a resource-generation directory in JKube Kit docs and move all resource configuration related documentation there. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
…onfiguration + Add documentation for `controller` configuration in `resource` + Deprecate existing controller configuration fields directly available in `resource` Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
doc/issue1316
branch
from
February 13, 2023 15:11
0ebea0e
to
d358f6b
Compare
Kudos, SonarCloud Quality Gate passed! |
This was referenced Feb 16, 2023
manusa
approved these changes
Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #1316, fixes #2044
controller
configuration inresource
resource
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist