feat (jkube-kit/common) : Add CliDownloaderUtil to download cli binaries (#2454) #2476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2476 (2023-11-30T12:14:57Z) ⚙️ JKube E2E Tests (7046183039)
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2476 +/- ##
============================================
+ Coverage 59.36% 68.95% +9.59%
- Complexity 4586 4832 +246
============================================
Files 500 474 -26
Lines 21211 19143 -2068
Branches 2830 2492 -338
============================================
+ Hits 12591 13200 +609
+ Misses 7370 4743 -2627
+ Partials 1250 1200 -50 ☔ View full report in Codecov by Sentry. |
rohanKanojia
force-pushed
the
pr/issue2454-part1
branch
4 times, most recently
from
fa43af8
to
b3342b0
Compare
rohanKanojia
changed the title
rohanKanojia
force-pushed
the
pr/issue2454-part1
branch
from
b3342b0
to
cb67e87
Compare
rohanKanojia
force-pushed
the
pr/issue2454-part1
branch
2 times, most recently
from
a75361d
to
ce9ee5d
Compare
manusa
requested changes
Nov 29, 2023
| public class CliDownloaderUtil { | ||
| private CliDownloaderUtil() { } | ||
|
|
||
| public static String downloadCli(String baseDownloadUrl, String cliBinaryPrefix, String cliArtifactName, File outputDirectory) throws IOException { |
There was a problem hiding this comment.
I'm still not sure why we need to compute the final URI from different components.
Also, I don't understand why the return type is a String instead of a Path or a File.
Some Javadoc to document the method would be nice too.
| import static org.apache.commons.io.FilenameUtils.removeExtension; | ||
| import static org.eclipse.jkube.kit.common.archive.ArchiveDecompressor.extractArchive; | ||
|
|
||
| public class CliDownloaderUtil { |
There was a problem hiding this comment.
What is Cli in this context?
Is this class suppose to help download any kind of CLI tool?
There was a problem hiding this comment.
Is this comment regarding naming of class or to add javadocs?
Comment on lines
62
to
69
| private static String getCliBinaryPathFromExtractedDir(File targetExtractionDir, String binaryPrefix) { | ||
| String cliPath = null; | ||
| File[] cliArtifactList = targetExtractionDir.listFiles(f -> f.getName().startsWith(binaryPrefix)); | ||
| if (cliArtifactList != null && cliArtifactList.length >= 1) { | ||
| cliPath = cliArtifactList[0].getAbsolutePath(); | ||
| } | ||
| return cliPath; | ||
| } |
There was a problem hiding this comment.
Is this behavior consistent for any CLI we decide to download using this util class?
There was a problem hiding this comment.
Shall we check if file is executable rather than name?
There was a problem hiding this comment.
I was trying with canExecute fileter but it doesn't seem to work. We seem to be losing permissions while decompressing archive .
There was a problem hiding this comment.
There is also option to select file with largest size.
rohanKanojia
force-pushed
the
pr/issue2454-part1
branch
3 times, most recently
from
9acda06
to
d925864
Compare
…ad archives (eclipse-jkube#2454) + Refactor IoUtil.download method to be able to extract response body for further consumption + Add IoUtil.downloadArchive method to download and extract archive to specified folder Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue2454-part1
branch
from
d925864
to
00bc529
Compare
manusa
approved these changes
Nov 30, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2454
Add CliDownloaderUtil to download CLI binaries from remote sources.
Type of change
test, version modification, documentation, etc.)
Checklist