chore(deps): Bump version.kubernetes-client from 6.9.2 to 6.10.0 #2532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #2532 (2024-01-16T06:02:28Z) ⚙️ JKube E2E Tests (7537592493)
|
manusa
force-pushed
the
deps/kubernetes-client
branch
from
5384e39
to
7e08072
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #2532 +/- ##
=============================================
+ Coverage 59.36% 69.86% +10.50%
- Complexity 4586 4904 +318
=============================================
Files 500 474 -26
Lines 21211 19173 -2038
Branches 2830 2480 -350
=============================================
+ Hits 12591 13396 +805
+ Misses 7370 4561 -2809
+ Partials 1250 1216 -34 ☔ View full report in Codecov by Sentry. |
|
Wrong. It has something to do with the KubernetesClient initialization, it seems to be getting stuck somewhere. Maybe there is indeed a bug in the KubernetesClient (probably with the recent changes in the Config class). |
manusa
force-pushed
the
deps/kubernetes-client
branch
2 times, most recently
from
66b8ca2
to
e04c18f
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
deps/kubernetes-client
branch
from
e04c18f
to
2d9b20d
Compare
|
After many hours 😭 of investigation, I managed to isolate the issue. The problem is that the bytecode provided by commons-compress 1.24.0 and commons-compress 1.25.0 seems to not be compatible (I can't figure out why, though). However, this doesn't manifest anywhere, the execution is stopped exception at this point https://github.com/fabric8io/kubernetes-client/blob/af9ff5f1ade084c3d54d87a7b26387620fe43685/kubernetes-client/src/main/java/io/fabric8/kubernetes/client/dsl/internal/uploadable/PodUpload.java#L173 If the expression is evaluated in the debugger the following Error This is encompassed within a try-with-resources block in an asynchronous environment, so whatever A simple bump of the commons-compress library to the one expected by the Fabric8 Kubernetes Client seems to have fixed the issue. |
|
rohanKanojia
approved these changes
Jan 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
chore(deps): Bump version.kubernetes-client from 6.9.2 to 6.10.0
Type of change
test, version modification, documentation, etc.)
Checklist