-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update KubernetesLogTaskTest.java #2740
Update KubernetesLogTaskTest.java #2740
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2740 (2024-03-05T06:01:00Z) ⚙️ JKube E2E Tests (8151649292)
|
build is failing due to #2742 |
@AjaySDwivedi1 : Could you please rebase your branch against master? |
Sorry this might seem like a dumb question, but what does rebase mean? Is it similar to merging? |
@AjaySDwivedi1 : You're right, git rebase is somewhat similar to git merge, it's really handy when your branch gets outdated with newly pushed changes in main branch. |
There is a small issue right now. The laptop I use is not working, so I won't be able to do that as of right now. Do I need to do another PR after the rebase? |
You don't need to create another pull request, you can rebase and force push to the existing branch. |
Deleted the exception Signed-off-by: Ajay Dwivedi <adwived@clemson.edu>
73d4ade
to
6d946a0
Compare
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2740 +/- ##
=============================================
+ Coverage 59.36% 70.57% +11.21%
- Complexity 4586 5012 +426
=============================================
Files 500 486 -14
Lines 21211 19457 -1754
Branches 2830 2504 -326
=============================================
+ Hits 12591 13732 +1141
+ Misses 7370 4502 -2868
+ Partials 1250 1223 -27 ☔ View full report in Codecov by Sentry. |
Description
Fixes #2672
Type of change
test, version modification, documentation, etc.)
Checklist