-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#2847 OpenShift route generated targetPort doesn't use the service "targetPort" #2850
Conversation
Eclipse JKube CI ReportStarted new GH workflow run for #2850 (2024-03-26T19:38:19Z) ⚙️ JKube E2E Tests (8441756189)
|
9e901fd
to
deafac5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look good to me.
However, some of the integration tests are failing:
[INFO] Results:
[INFO]
[ERROR] Errors:
[ERROR] ExposeIT.ocResource_whenRun_generatesOpenShiftManifestsWithProjectLabels:105 » IllegalArgument JSONArray size mismatch for JSON entry 'items', expected '7' but was '5'
[ERROR] MultipleServicesIT.ocResource_whenRun_generatesOpenShiftManifests:53 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '9376'
[ERROR] RouteNameAndFragmentIT.ocResourceTask:42 » IllegalArgument Values not equal for entry: 'targetPort', expected '9090' but was '8080'
[ERROR] ServiceNameAndFragmentIT.ocResourceTask:58 » IllegalArgument Values not equal for entry: 'targetPort', expected '9090' but was '8080'
[ERROR] VolumePermissionIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithPersistentVolume:75 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '5000'
[ERROR] VolumePermissionIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithPersistentVolume:75 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '5000'
[ERROR] VolumePermissionIT.ocResourceTask_whenRun_generatesOpenShiftManifestWithPersistentVolume:75 » IllegalArgument Values not equal for entry: 'targetPort', expected '80' but was '5000'
Failures are likely due to invalid expectations.
You also need to sign the ECA so that we are able to merge these changes.
Let me know if you need any help with any of the 2 missing tasks.
…he service "targetPort"
Quality Gate passedIssues Measures |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2850 +/- ##
=============================================
+ Coverage 59.36% 70.62% +11.25%
- Complexity 4586 5017 +431
=============================================
Files 500 486 -14
Lines 21211 19466 -1745
Branches 2830 2507 -323
=============================================
+ Hits 12591 13747 +1156
+ Misses 7370 4494 -2876
+ Partials 1250 1225 -25 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx!
Description
Fixes #2847
According to Openshift API specification,
spec.port.targetPort
have to be set with the target port of the service that the route try to expose:At the moment, openshift maven plugin use service set the route targetPort to service port.
https://docs.openshift.com/container-platform/4.15/rest_api/network_apis/route-route-openshift-io-v1.html#spec-port
Type of change