Chore/unused imports in kubernetes config auth util test #3003
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pratikgurjar
requested review from
manusa,
rohanKanojia and
sunix
as code owners
Eclipse JKube CI ReportStarted new GH workflow run for #3003 (2024-04-30T13:29:43Z) ⚙️ JKube E2E Tests (8895474054)
|
rohanKanojia
approved these changes
Apr 30, 2024
|
@pratikgurjar : Please ask on the issue to get assigned first before creating pull request directly. |
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3003 +/- ##
=============================================
+ Coverage 59.36% 70.81% +11.45%
- Complexity 4586 5081 +495
=============================================
Files 500 489 -11
Lines 21211 19580 -1631
Branches 2830 2527 -303
=============================================
+ Hits 12591 13866 +1275
+ Misses 7370 4486 -2884
+ Partials 1250 1228 -22 ☔ View full report in Codecov by Sentry. |
pratikgurjar
deleted the
fix/unused-imports-in-KubernetesConfigAuthUtilTest
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Removed and rerranged the unused import from KubernetesConfigAuthUtilTest fileFixes #2925
Type of change
test, version modification, documentation, etc.)
Checklist
- [x ] I have read the contributing guidelines
- [ x] I signed-off my commit with a user that has signed the Eclipse Contributor Agreement
- [x ] My code follows the style guidelines of this project
- [x ] I Keep It Small and Simple: The smaller the PR is, the easier it is to review and have it merged
- [ x] I use conventional commits in my commit messages
- [ x] I have performed a self-review of my code
- I Added CHANGELOG entry
- I have updated the documentation accordingly
- [x ] No new bugs, code smells, etc. in SonarCloud report
- I have added tests that prove my fix is effective or that my feature works
- New and existing unit tests pass locally with my changes
- [x ] I tested my code in Kubernetes
- [ x] I tested my code in OpenShift
its ready