-
Notifications
You must be signed in to change notification settings - Fork 521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(jib): support building images from scratch #3091
Conversation
Signed-off-by: Marc Nuri <marc@marcnuri.com>
Eclipse JKube CI ReportStarted new GH workflow run for #3091 (2024-05-23T08:45:43Z) ⚙️ JKube E2E Tests (9204360682)
|
void setUp() { | ||
imageConfiguration = imageConfiguration.toBuilder() | ||
.build(imageConfiguration.getBuild().toBuilder() | ||
.from("gcr.io/distroless/base@sha256:8267a5d9fa15a538227a8850e81cf6c548a78de73458e99a67e8799bbffb1ba0") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
was that part not necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not anymore
It was necessary because from scratch wasn't supported
Quality Gate passedIssues Measures |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3091 +/- ##
=============================================
+ Coverage 59.36% 71.03% +11.67%
- Complexity 4586 5078 +492
=============================================
Files 500 489 -11
Lines 21211 19452 -1759
Branches 2830 2502 -328
=============================================
+ Hits 12591 13818 +1227
+ Misses 7370 4415 -2955
+ Partials 1250 1219 -31 ☔ View full report in Codecov by Sentry. |
Description
Relates to #2098
Type of change
test, version modification, documentation, etc.)
Checklist