fix (jkube-kit-spring-boot) : Directly read layers.idx file to get layers information
#3236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #3236 (2024-07-18T14:34:13Z) ⚙️ JKube E2E Tests (9992665491)
|
rohanKanojia
changed the title
layers.idx file to get layers information
rohanKanojia
force-pushed
the
pr/issue3228
branch
from
4096a5c
to
0ffa906
Compare
manusa
reviewed
Jul 18, 2024
manusa
reviewed
Jul 18, 2024
Comment on lines
72
to
73
| String layerFileContent = IOUtils.toString(jarFile.getInputStream(jarFile.getEntry("BOOT-INF/layers.idx")), StandardCharsets.UTF_8); | ||
| List<Map<String, List<String>>> layers = Serialization.unmarshal(layerFileContent, List.class); |
There was a problem hiding this comment.
Why aren't we using Serialization.unmarshal from InputSream?
There was a problem hiding this comment.
oh, okay. let me use that method.
We have SpringBootLayeredJarTest that verifies layer list with real jar and fake jar (created within test) |
…yers information Till now we were executing layertools list command to extract layer related information for Spring Boot Layered jar. This has started causing problems in Spring Boot 3.3.x where we're getting additional deprecation warning that's breaking behavior of SpringBootGenerator. Additionally, layertools command has become deprecated in Spring Boot 3.3.x Instead of relying on layertools command, directly read layers.idx file present in layered jar to extract list of layers. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue3228
branch
from
0ffa906
to
474683e
Compare
OK, that's cool. It means that regardless of the underlying implementation, the black-boxed test is working as expected 🎉 |
|
Yes, on top of that we also have CompleteOcDockerLayersDisabledITCase to verify that plugin works with or without layer functionality |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #3228
Till now we were executing layertools list command to extract layer related information for Spring Boot Layered jar. This has started causing problems in Spring Boot 3.3.x where we're getting additional deprecation warning that's breaking behavior of SpringBootGenerator. Additionally, layertools command has become deprecated in Spring Boot 3.3.x
Instead of relying on layertools command, directly read layers.idx file present in layered jar to extract list of layers.
layers.idxfile format seems to be consistent across previous Spring Boot versions. You can see it's spec in LayersIndex.java :Existing tests verify that the SpringBootLayeredJar works as expected even after making this change.
Type of change
test, version modification, documentation, etc.)
Checklist