feat (jkube-kit/helm) : Add support for generating helm test resources via fragments #3346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eclipse JKube CI ReportStarted new GH workflow run for #3346 (2024-09-23T12:20:00Z) ⚙️ JKube E2E Tests (10993861020)
|
rohanKanojia
force-pushed
the
pr/issue2375
branch
2 times, most recently
from
3b3933b
to
04f8386
Compare
rohanKanojia
force-pushed
the
pr/issue2375
branch
from
04f8386
to
acbb149
Compare
rohanKanojia
force-pushed
the
pr/issue2375
branch
from
acbb149
to
ee82a98
Compare
…s via fragments + Add support for generating helm test resources. User would place a test fragment in src/main/jkube directory and it would be copied to templates/tests during helm chart generation. + Only fragments ending with `.test.helm.yaml` suffix would be considered for helm test resources. Signed-off-by: Rohan Kumar <rohaan@redhat.com>
rohanKanojia
force-pushed
the
pr/issue2375
branch
from
ee82a98
to
0565625
Compare
Signed-off-by: Marc Nuri <marc@marcnuri.com>
manusa
force-pushed
the
pr/issue2375
branch
from
ea960c3
to
0d849f0
Compare
|
rohanKanojia
added a commit
to rohanKanojia/jkube
that referenced
this pull request
Sep 24, 2024
… while interpolating chart templates Follow up to eclipse-jkube#3346 + Modify HelmService's interpolateChartTemplates method to look for chart templates recursively as now chart templates can also be test templates that usually reside in `templates/tests/` directory. + We already have a method named `listYamls` in YamlUtil that lists yaml files in a specified directory. Add another method that would do the recursive listing based on boolean flag Signed-off-by: Rohan Kumar <rohaan@redhat.com>
17 tasks
manusa
added a commit
that referenced
this pull request
Sep 25, 2024
…terpolation (3398) fix (jkube-kit/helm) : HelmService should check in nested directories while interpolating chart templates Follow up to #3346 + Modify HelmService's interpolateChartTemplates method to look for chart templates recursively as now chart templates can also be test templates that usually reside in `templates/tests/` directory. + We already have a method named `listYamls` in YamlUtil that lists yaml files in a specified directory. Add another method that would do the recursive listing based on boolean flag Signed-off-by: Rohan Kumar <rohaan@redhat.com> --- review: helm test directory file interpolation Signed-off-by: Marc Nuri <marc@marcnuri.com> Co-authored-by: Marc Nuri <marc@marcnuri.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related to #2375
fragment in
src/main/jkubedirectory and it would be copied totemplates/testsduring helm chart generation..test.helm.yamlsuffix would be consideredfor helm test resources.
Signed-off-by: Rohan Kumar rohaan@redhat.com
Type of change
test, version modification, documentation, etc.)
Checklist