Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added NullCheck in FileDataSecretEnricher #98

Merged
merged 1 commit into from
Mar 9, 2020

Conversation

rohanKanojia
Copy link
Member

@codecov
Copy link

codecov bot commented Mar 6, 2020

Codecov Report

Merging #98 into master will decrease coverage by <.01%.
The diff coverage is 50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #98      +/-   ##
============================================
- Coverage     24.81%   24.81%   -0.01%     
  Complexity     1351     1351              
============================================
  Files           329      329              
  Lines         17691    17693       +2     
  Branches       2684     2686       +2     
============================================
  Hits           4390     4390              
  Misses        12791    12791              
- Partials        510      512       +2
Impacted Files Coverage Δ Complexity Δ
...eclipse/jkube/enricher/generic/SecretEnricher.java 32.14% <44.44%> (-0.59%) 5 <0> (ø)
...jkube/enricher/generic/FileDataSecretEnricher.java 85.18% <66.66%> (-3.28%) 7 <0> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d02f1e...836f271. Read the comment docs.

@manusa
Copy link
Member

manusa commented Mar 6, 2020

Changelog entry please

@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

66.7% 66.7% Coverage
0.0% 0.0% Duplication

@manusa manusa merged commit 374816b into eclipse-jkube:master Mar 9, 2020
@rohanKanojia rohanKanojia deleted the pr/portFMP-PR-1792 branch July 7, 2020 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants