-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement current state reporting for containers update agent #179
Merged
dimitar-dimitrow
merged 4 commits into
eclipse-kanto:update-agent
from
SoftwareDefinedVehicle:report-current-state
Jul 18, 2023
Merged
Implement current state reporting for containers update agent #179
dimitar-dimitrow
merged 4 commits into
eclipse-kanto:update-agent
from
SoftwareDefinedVehicle:report-current-state
Jul 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[eclipse-kanto#167] Implement current state reporting for containers update agent Also added xxxToString functions next to the available ParseXXX functions for containers device mappings, port mappings, mount points. Signed-off-by: Stoyan Zoubev <Stoyan.Zoubev@bosch.io>
Signed-off-by: Stoyan Zoubev <Stoyan.Zoubev@bosch.io>
I suggest the tests in from_container_test.go to be re-written as table driven tests as it is preferred way for unit tests in Go and is heavily used in the container-management repo . Currently some sub-test names are conflicting and test are hard to read.
|
Signed-off-by: Stoyan Zoubev <Stoyan.Zoubev@bosch.io>
dimitar-dimitrow
approved these changes
Jul 17, 2023
dimitar-dimitrow
added a commit
that referenced
this pull request
Aug 17, 2023
[#186] Implement containers update agent service Merge update-agent feature branch * Extend daemon configuration and dummy implementation for update agent (#168) * Upgrade google.golang.org/grpc to version 1.53.0 or later (#172) * Preparation for implementing apply of containers desired state (#175) * Implement apply of desired state for containers update agent (#177) * Implement current state reporting for containers update agent (#179) Signed-off-by: Kristiyan Gostev <kristiyan.gostev@bosch.com> Co-authored-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io> Co-authored-by: Stoyan Zoubev <Stoyan.Zoubev@bosch.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#167] Implement current state reporting for containers update agent
Also added xxxToString functions next to the available ParseXXX functions for containers device mappings, port mappings, mount points.
Signed-off-by: Stoyan Zoubev Stoyan.Zoubev@bosch.io