-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement signed images verification #94
Closed
dimitar-dimitrow
wants to merge
8
commits into
eclipse-kanto:dev-m5
from
bosch-io:signed-image-support
Closed
Implement signed images verification #94
dimitar-dimitrow
wants to merge
8
commits into
eclipse-kanto:dev-m5
from
bosch-io:signed-image-support
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-gostev
reviewed
Nov 18, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of nits
e-grigorov
suggested changes
Nov 18, 2022
k-gostev
approved these changes
Nov 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dimitar-dimitrow
force-pushed
the
signed-image-support
branch
from
December 5, 2022 14:23
2de53ea
to
c44606a
Compare
dimitar-dimitrow
force-pushed
the
signed-image-support
branch
from
December 16, 2022 07:57
c44606a
to
64410f2
Compare
k-gostev
suggested changes
Dec 16, 2022
dimitar-dimitrow
force-pushed
the
signed-image-support
branch
from
December 16, 2022 13:43
64410f2
to
c1f9f7c
Compare
dimitar-dimitrow
force-pushed
the
signed-image-support
branch
from
October 26, 2023 11:20
c1f9f7c
to
145ef6b
Compare
[67] Implement signed images verification - API for providing verification configuration per container - container-management flag for providing global verification configuration - verification manager API - verification manager implementation based on cosign - needed utility methods for parsing and validation - needed modification to pass current unit test - new dependencies are covered in NOTICE file Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
[67] Implement signed images verification - refactor verification mgr API - use spi for pull, get and delete of signature - use verification prefix instead of ver Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
[67] Implement signed images verification - verify_config -> verification_config Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
[67] Minor fixes - ctr_verification... renamed to ctrd_verification... - typos and other adjustments Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
[67] Fixed comments - changed API order and move to var args - verification logic moved from getImage to verifyImage - removed validation of verification configuration, errors would pop up during parsing - unit tests fixed accordingly Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
[67] Minor improvements Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
[67] Implement signed images verification Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
… ctr package [67] Implement signed images verification Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
dimitar-dimitrow
force-pushed
the
signed-image-support
branch
from
October 26, 2023 11:23
145ef6b
to
4313786
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#67] Implement signed images verification
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov3@bosch.io