Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove agent domain/name duplication in the config #38

Closed
dimitar-dimitrow opened this issue Aug 22, 2023 · 0 comments · Fixed by #39
Closed

Remove agent domain/name duplication in the config #38

dimitar-dimitrow opened this issue Aug 22, 2023 · 0 comments · Fixed by #39
Assignees
@dimitar-dimitrow
Labels
task Single unit of work
Milestone
M4

Comments

@dimitar-dimitrow
Copy link
Contributor

Currently the config of the UpdateManager duplicates domain/name configuration of an Update Agent, take a look at the containers agent and the agent name field value in the example below:

    "agents": {
        "containers": {
            "name": "containers",
            "rebootRequired": false,
            "readTimeout": "30s"
        }
    }

The name value should be skipped.
@dimitar-dimitrow dimitar-dimitrow added the task Single unit of work label Aug 22, 2023
@dimitar-dimitrow dimitar-dimitrow added this to the M4 milestone Aug 22, 2023
@dimitar-dimitrow dimitar-dimitrow self-assigned this Aug 22, 2023
dimitar-dimitrow added a commit to bosch-io/kanto-update-manager that referenced this issue Aug 22, 2023
@dimitar-dimitrow
[eclipse-kanto#38] Remove agent domain/name duplication in the config
043e92e 
 - skip the name field when unmarshalling
 - fill the names from the agents keys
 - fix unit test
 - update the service configuration

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
@dimitar-dimitrow dimitar-dimitrow mentioned this issue Aug 22, 2023
Merged
@dimitar-dimitrow dimitar-dimitrow linked a pull request Aug 22, 2023 that will close this issue
Remove agent domain/name duplication in the config #39
Merged
dimitar-dimitrow added a commit to bosch-io/kanto-update-manager that referenced this issue Aug 22, 2023
@dimitar-dimitrow
[eclipse-kanto#38] Remove unnecessary comment
cfc5b6e 
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
k-gostev pushed a commit that referenced this issue Aug 22, 2023
@dimitar-dimitrow
Remove agent domain/name duplication in the config (#39)
495d9ab 
* [#38] Remove agent domain/name duplication in the config

---------

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.io>
This was referenced Aug 24, 2023
Closed
Closed
@dimitar-dimitrow dimitar-dimitrow mentioned this issue Aug 31, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitar-dimitrow dimitar-dimitrow

Labels
task Single unit of work
Projects
Eclipse Kanto
Status: Done
Milestone
M4
Development

Successfully merging a pull request may close this issue.

Remove agent domain/name duplication in the config bosch-io/kanto-update-manager
1 participant
@dimitar-dimitrow