Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#58] Request device owner's approval #59

Merged
merged 6 commits into from
May 13, 2024

Conversation

dimitar-dimitrow
Copy link
Contributor

@dimitar-dimitrow dimitar-dimitrow commented Apr 19, 2024

[#58] Request device owner's approval

  • add config before which phases a owner consent will be needed
  • owner consent API
  • add owner consent client, used internally in UM
  • add owner consent agent client, to be used by the app getting the owner approval
  • modify orchestrator to wait for a owner consent
  • unit test

Signed-off-by: Dimitar Dimitrov dimitar.dimitrov3@bosch.com

- add config before which phases a owner consent will be needed
- owner consent API
- add owner consent client, used internally in UM
- add owner consent agent client, to be used by the app getting the owner approval
- modify orchestrator to wait for a owner consent
- unit test

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
@dimitar-dimitrow dimitar-dimitrow linked an issue Apr 19, 2024 that may be closed by this pull request
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
 - add command to the consent request
 - remove phases and re-use desired state command values
 - remove unit test will be added in separate PR

Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
Copy link
Member

@k-gostev k-gostev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of small comments, otherwise looks good

api/types/owner_consent.go Outdated Show resolved Hide resolved
api/types/owner_consent.go Outdated Show resolved Hide resolved
config/flags_internal.go Outdated Show resolved Hide resolved
go.mod Show resolved Hide resolved
mqtt/owner_consent_agent_client .go Show resolved Hide resolved
updatem/orchestration/update_orchestrator.go Outdated Show resolved Hide resolved
updatem/orchestration/update_orchestrator_apply.go Outdated Show resolved Hide resolved
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
@k-gostev k-gostev merged commit 7ba526a into eclipse-kanto:main May 13, 2024
2 checks passed
@k-gostev k-gostev deleted the owner-consent branch May 13, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request device owner's approval
2 participants