-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#58] Request device owner's approval #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add config before which phases a owner consent will be needed - owner consent API - add owner consent client, used internally in UM - add owner consent agent client, to be used by the app getting the owner approval - modify orchestrator to wait for a owner consent - unit test Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
- add command to the consent request - remove phases and re-use desired state command values - remove unit test will be added in separate PR Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
dimitar-dimitrow
force-pushed
the
owner-consent
branch
from
April 24, 2024 16:51
1585e30
to
2451dc0
Compare
k-gostev
suggested changes
Apr 29, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of small comments, otherwise looks good
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
Signed-off-by: Dimitar Dimitrov <dimitar.dimitrov3@bosch.com>
k-gostev
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[#58] Request device owner's approval
Signed-off-by: Dimitar Dimitrov dimitar.dimitrov3@bosch.com