Use microseconds instead of milliseconds to generate higher throughput

[rafaeling]

No description provided.

[erikbosch]

What happens if you use an "old" config file, like the ones in https://github.com/boschglobal/kuksa-perf/tree/fix/cycle_time_microseconds/data

Will you get an error or will it silently just ignore the old setting? I would prefer that it gives an error so that it just not silently ignore the old setting.

Are there more existing scripts that needs to be updated?

[rafaeling]

What happens if you use an "old" config file, like the ones in https://github.com/boschglobal/kuksa-perf/tree/fix/cycle_time_microseconds/data

Will you get an error or will it silently just ignore the old setting? I would prefer that it gives an error so that it just not silently ignore the old setting.

Are there more existing scripts that needs to be updated?

Forgot to push the modified files

[erikbosch]

Just want to make sure that it is intentional to change semantic meaning of the example, i.e. that we in some cases (like here) keep the numeric value, in other multiply be 100

[rafaeling]

It was actually non intentional, just left some value, provided more realistic values

[erikbosch]

LGTM

[argerus]

I think it makes a lot more sense to keep the "cycle_time_ms" in order to not break all old configs. In addition, I think it's a lot more common to specify cycle time in milliseconds rather than microseconds.

TL;DR
Add "cycle_time_us" in addition to "cycle_time_ms" instead of replacing it.

EDIT: Or skip adding "cycle_time_us" altogether and instead have the existing config accept a decimal number for the cycle time, e.g. "cycle_time_ms": 0.1.

[argerus]

Instead of hardcoding it to either ms or microseconds (and choosing between a u16 and u32), it would be better to store it as a Duration. That's what we want in the end anyway, and would make it equally easy to set with either milliseconds, microseconds or anything else as input.

[argerus]

What happens if you use an "old" config file, like the ones in https://github.com/boschglobal/kuksa-perf/tree/fix/cycle_time_microseconds/data

Will you get an error or will it silently just ignore the old setting? I would prefer that it gives an error so that it just not silently ignore the old setting.

Are there more existing scripts that needs to be updated?

If we need to support specifying the cycle time in microseconds I would much prefer to add this in addition to the existing configuration option, i.e. support both "cycle_time_ms" and "cycle_time_microseconds". That has the added benefit of not breaking any existing test setups. It also removes the need to add a whole lot of zeroes when specifying common cycle times.

EDIT: Or just have "cycle_time_ms" accept decimal numbers.