This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Remove staticx #83
Merged
Remove staticx #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
reviewed
Apr 13, 2023
dbc2val/Dockerfile
Outdated
| @@ -31,35 +33,26 @@ ENV PATH="/opt/venv/bin:$PATH" | |||
| RUN /opt/venv/bin/python3 -m pip install --upgrade pip \ | |||
| && pip3 install --no-cache-dir -r requirements.txt | |||
|
|
|||
| RUN pip3 install wheel scons && pip3 install pyinstaller patchelf==0.17.0.0 staticx | |||
| RUN pip3 install wheel scons && pip3 install pyinstaller | |||
There was a problem hiding this comment.
Based on our recent problems with pyinstaller (well actually with staticx it seems) I am thinking if we in the long run should handle the dependencies here similar to our requirements* files, i.e. directly or indirectly specify exact version so we can always "rebuild" the same docker container. Maybe not for main/master, but maybe for releases.
There was a problem hiding this comment.
Should we add it to dev-dependencies? Or create a seperate "requirements-package.in" or something, generate it and pip-install it as well?
erikbosch
approved these changes
Apr 13, 2023
erikbosch
reviewed
Apr 13, 2023
This was referenced Apr 13, 2023
SebastianSchildt
force-pushed
the
test/docker
branch
from
6728ed9 to
6bda6f3
Compare
SebastianSchildt
force-pushed
the
test/docker
branch
3 times, most recently
from
c4e64c1 to
d744c04
Compare
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
Signed-off-by: Sebastian Schildt <sebastian.schildt@de.bosch.com>
SebastianSchildt
force-pushed
the
test/docker
branch
from
d744c04 to
c06ba37
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think "size-wise" we can get rid of staticx, and this is one quick shot at it.
Advantages
Disadvantages
The current size on arm64
I did test, it can start and play logfile to dataroker, I had no way to