This repository has been archived by the owner on Sep 2, 2024. It is now read-only.
Adapting to VSS 4.0 #96
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erikbosch
commented
May 5, 2023
erikbosch
force-pushed
the
erikbosch/erik_vss
branch
from
b36a15e to
60d335c
Compare
Merged
erikbosch
force-pushed
the
erikbosch/erik_vss
branch
3 times, most recently
from
4046b35 to
a3c37d7
Compare
erikbosch
commented
May 12, 2023
|
Now things seems to work, but some refactoring in ddsprovider required to support use-cases where we cannot use "latest master" of databroker. I think this one is ready for an internal review. I have verified ddsprovider and dbcfeeder. |
erikbosch
force-pushed
the
erikbosch/erik_vss
branch
from
a3c37d7 to
3b6b801
Compare
lukasmittag
reviewed
May 23, 2023
| # Now test some transforms | ||
| result = vss_mapping.transform_value(25.3) | ||
| assert result == 25.3 | ||
|
|
||
|
|
||
| def test_vehicle_obd_speed(): | ||
| dbc_mapping = mapper["DI_uiSpeed"] | ||
| assert len(dbc_mapping) == 2 |
erikbosch
force-pushed
the
erikbosch/erik_vss
branch
from
3b6b801 to
24a2b7d
Compare
|
@lukasmittag - could you check my answers above - if there is any remaining fixes to do? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapting to VSS 4.0 based on release candidate.