Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(distrib)!: Remove Intel UP2 and Nvidia Jetson Nano profiles #5315

Merged
merged 4 commits into from
Jul 16, 2024
Merged

refactor(distrib)!: Remove Intel UP2 and Nvidia Jetson Nano profiles #5315

merged 4 commits into from
Jul 16, 2024

Conversation

pierantoniomerlino
Copy link
Contributor

@pierantoniomerlino pierantoniomerlino commented Jul 11, 2024 •
edited
Loading

Note: We are using the Conventional Commits convention for our pull request titles. Please take a look at the PR title format document for the supported types and scopes.

This PR removes the Intel UP2 and Nvidia Jetson Nano profiles. These will be replaced by the generic profiles.
Moreover, the references to the old networking (and files) have been deleted from the distrib project.

@pierantoniomerlino pierantoniomerlino changed the title Remove old networking profiles refactor(distrib): Remove old networking profiles Jul 11, 2024
@pierantoniomerlino pierantoniomerlino changed the title refactor(distrib): Remove old networking profiles refactor(distrib): Remove Intel UP2 and Nvidia Jetson Nano profiles Jul 11, 2024
@pierantoniomerlino pierantoniomerlino marked this pull request as ready for review July 11, 2024 14:57
@pierantoniomerlino pierantoniomerlino marked this pull request as draft July 11, 2024 15:05
@pierantoniomerlino pierantoniomerlino marked this pull request as ready for review July 11, 2024 15:24
@mattdibi
Copy link
Contributor

mattdibi commented Jul 12, 2024 •
edited
Loading

@pierantoniomerlino BTW is this a breaking change? If so we should append a ! to the commit type as per our commit convention.

@pierantoniomerlino pierantoniomerlino changed the title refactor(distrib): Remove Intel UP2 and Nvidia Jetson Nano profiles refactor(distrib)!: Remove Intel UP2 and Nvidia Jetson Nano profiles Jul 15, 2024
mattdibi
mattdibi approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@mattdibi mattdibi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 One of the best PRs I've ever reviewed.

@pierantoniomerlino
Removed Up2 and Nano profiles
ad5228d 
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
@pierantoniomerlino
Removed Up2 and Nano profiles from pom
91a0daa 
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
@pierantoniomerlino
Removed network.provider property; removed nano references from ant s…
de673d9 
…cript

Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
@pierantoniomerlino
Deleted files for old networking
8e6e3c8 
Signed-off-by: pierantoniomerlino <pierantonio.merlino@eurotech.com>
@pierantoniomerlino pierantoniomerlino force-pushed the remove_old_networking_profiles branch from ee726e7 to 8e6e3c8 Compare July 16, 2024 10:49
@pierantoniomerlino pierantoniomerlino merged commit 93c08c3 into develop Jul 16, 2024
7 checks passed
@pierantoniomerlino pierantoniomerlino deleted the remove_old_networking_profiles branch July 16, 2024 13:09
This was referenced Aug 28, 2024
Merged
Closed
@mattdibi mattdibi mentioned this pull request Sep 17, 2024
Merged
@mattdibi mattdibi mentioned this pull request Jan 20, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattdibi mattdibi mattdibi approved these changes

@MMaiero MMaiero Awaiting requested review from MMaiero

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pierantoniomerlino @mattdibi