Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rearrange documentation and add "learn the workflow" section #223

Merged
merged 19 commits into from
May 14, 2024

Conversation

Lotes
Copy link
Contributor

@Lotes Lotes commented Apr 5, 2024

I reorganized the documentation in this PR. I do not want to delete any existing pages, but sometimes they are a bit long and misleading. Most of them are fine for me.
I also added a learning section where (new) the basic workflow with Langium gets explained.

  • everything from "old/Guides" you can find under "new/Recipes"
  • everything from "old/Tutorials" you can find under "new/Learn/Minilogo"
  • everything from "old/Documentation" got intermixed (WIP)
    • "old/Documentation/Langium Overview" you can find under "new/What is Langium/Features"
    • "old/Documentation/Getting started" you can find under "new/Reference/Glossary" and several "new/Learn/Workflow/*"
    • the remaining part of "old/Documentation" you can find under "new/Reference"

@Lotes Lotes temporarily deployed to pull-request-preview April 5, 2024 15:16 — with GitHub Actions Inactive
Copy link

github-actions bot commented Apr 5, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-05-14 11:37 UTC

@Lotes Lotes temporarily deployed to pull-request-preview April 11, 2024 13:45 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview April 11, 2024 14:43 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview April 11, 2024 14:59 — with GitHub Actions Inactive
@JohannesMeierSE
Copy link
Contributor

@Lotes I wrote a tutorial about keywords as identifiers in #219, but it is not yet merged. Maybe it belongs to "Recipes"? It could be seen as a tutorial as well, but it is not related to Minilogo, therefore "Minilogo tutorial" would not fit as category.

@Lotes
Copy link
Contributor Author

Lotes commented Apr 15, 2024

@JohannesMeierSE

I would put it under recipes, since it is not really learning the workflow, it is some kind of feature you want to talk about.

The Minilogo tutorial is also some kind of learning + multiple recipes, and I think maybe we should adapt it to fit more with the workflow. On the other hand... each project has its own challenges and therefore differs from the core workflow.

@JohannesMeierSE
Copy link
Contributor

I got some ideas in detail:

  • I would place "Code Bundling" as last point in "Recipes", since it is the final thing you would do. Having "Scoping" as one of the most important things at position 1 makes sense for me.
  • At the moment, "Documentation" is an empty page: Maybe, we could place here some tips, when to read which parts of the documentation?

Regarding "Our Workflow":

  • I would rename it to "Langium's Workflow", since I don't like "Our", that sounds a bit like suggestions of TypeFox.
  • Adding numbers 1, 2, 3, ... before the names in the outline/TOC in the left side bar would improve the readability and the steps.
  • Having the names in the workflow diagram and in the side bar 100% the same makes it easier to match the steps.

For the "Workflow diagram":

  • I would treat "Find advanced topics" not as a step, in particular, not as the picture suggests: After applying an advanced topic, you cannot iterate your DSL anymore (that is, what the diagram tells the reader). You want to say, that there is much more, which does not fit into these seven steps. Therefore, I suggest to say, that these 7 steps reflect the base workflow, in particular, for becoming familiar with Langium, but there are much more advanced topics in "Recipes".
  • Maybe, you could have a dedicated section for the "Initial Set-up" before the section for the "Core workflow"? Than all steps are visually represented in the same way.

Nevertheless, I like your clear steps a lot and I think, they will help newcomers a lot!
My comments target only some details of the updated documentation structure.

@Lotes Lotes temporarily deployed to pull-request-preview April 15, 2024 14:48 — with GitHub Actions Inactive
@Lotes
Copy link
Contributor Author

Lotes commented Apr 15, 2024

Thank you, @JohannesMeierSE . I made all these changes.

@Lotes Lotes temporarily deployed to pull-request-preview April 15, 2024 15:03 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview April 18, 2024 14:46 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview April 18, 2024 15:02 — with GitHub Actions Inactive
@Lotes Lotes changed the title WIP: Rearrange documentation and add "learn the workflow" section Rearrange documentation and add "learn the workflow" section Apr 18, 2024
@Lotes Lotes marked this pull request as ready for review April 18, 2024 15:08
@Lotes Lotes requested a review from gfontorbe April 19, 2024 19:18
@Lotes
Copy link
Contributor Author

Lotes commented Apr 20, 2024

Add a hint on names for resolving scope. The name is the key to resolve cross-references.

@Lotes Lotes added the documentation Improvements or additions to documentation label Apr 20, 2024
Copy link
Contributor

@gfontorbe gfontorbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the new flow of the documentation! Thanks a lot @Lotes.

Just a couple minor suggestions

hugo/content/docs/introduction/_index.md Outdated Show resolved Hide resolved
hugo/content/docs/introduction/_index.md Outdated Show resolved Hide resolved
hugo/content/docs/recipes/_index.md Outdated Show resolved Hide resolved
@insafuhrmann insafuhrmann self-requested a review April 26, 2024 12:41
Copy link
Contributor

@insafuhrmann insafuhrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for your PR, @Lotes. I like the new flow very much and also the additions you made. I just added a few detail remarks.

hugo/config.toml Show resolved Hide resolved
hugo/content/docs/learn/workflow/_index.md Outdated Show resolved Hide resolved
hugo/content/docs/learn/workflow/_index.md Outdated Show resolved Hide resolved
hugo/content/docs/learn/workflow/_index.md Outdated Show resolved Hide resolved
hugo/content/docs/learn/workflow/_index.md Show resolved Hide resolved
hugo/content/docs/learn/workflow/write_grammar.md Outdated Show resolved Hide resolved
hugo/content/docs/recipes/multiple-languages.md Outdated Show resolved Hide resolved
hugo/content/docs/reference/glossary.md Outdated Show resolved Hide resolved
@Lotes Lotes temporarily deployed to pull-request-preview May 13, 2024 08:40 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 13, 2024 11:14 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 13, 2024 13:00 — with GitHub Actions Inactive
@Lotes Lotes temporarily deployed to pull-request-preview May 13, 2024 13:03 — with GitHub Actions Inactive
@Lotes Lotes merged commit 41ee937 into main May 14, 2024
4 checks passed
@Lotes Lotes deleted the lotes/documentation-refactoring branch May 14, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants