Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update imports to match latest #251

Merged
merged 1 commit into from
Aug 24, 2024
Merged

Conversation

thejoecode
Copy link
Contributor

LangiumDocumentFactory was missing and LangiumSharedServices has moved to langium/lsp

LangiumDocumentFactory was missing and LangiumSharedServices has moved to langium/lsp
Copy link

github-actions bot commented Aug 23, 2024

PR Preview Action v1.4.6
Preview removed because the pull request was closed.
2024-08-24 10:53 UTC

@msujew
Copy link
Member

msujew commented Aug 23, 2024

Hey @thejoecode, thank you for the contribution!

In order to accept changes (unfortunately, no matter how small they are) we require all contributors to sign the Eclipse Contributor Agreement (ECA) with the same email that was used to create the commit.

It's understandable if you don't want to do that for this small of a change - in that case I just need your approval to resubmit your changes as mine :)

@thejoecode
Copy link
Contributor Author

Hey @thejoecode, thank you for the contribution!

In order to accept changes (unfortunately, no matter how small they are) we require all contributors to sign the Eclipse Contributor Agreement (ECA) with the same email that was used to create the commit.

It's understandable if you don't want to do that for this small of a change - in that case I just need your approval to resubmit your changes as mine :)

I have signed the ECA and re-validated that step. Thanks for the heads up on making the email match.

Copy link
Member

@msujew msujew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, thanks 👍

@msujew msujew merged commit 6f5aaa3 into eclipse-langium:main Aug 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants