-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split generated yeoman project into npm workspace #1495
Comments
Is this the desired output if all options are selected?
|
@Yokozuna59 Yes, exactly :) |
@Yokozuna59 I want to take care of this and update to |
@kaisalmen Absolutely. |
Shall the workspace split be an option so users can choose? |
@spoenemann I'd argue that unless it's a pure language project, it's always preferable to split the project into multiple workspaces. Even just with Langium+VSCode. |
@msujew and @Yokozuna59 in the above structure cli is included in the language package. In I started working on this today and the first point was to organize the template data directly into packages ( |
Initially, I thought of the same thing, but @msujew said:
He didn't mention the cli, so I aligned the output, following this suggestion. As for me, I would also recommend adding a separate cli package since most packages out there, including you guys, have a separate cli package. |
Yes, that makes sense 👍 |
Will do, thanks for the feedback 👍 |
WIP PR is up. ⬆️ It doesn't work, yet fully. Overall project structure looks good already, though. |
Hello @kaisalmen, I was starting a new (my first) Langium project when I noticed this issue and PR, and I was wondering if it is worth waiting for the PR to be merged. I see that all of the TODOs have already been checked, so is there an ETA on when it will be ready to use? It just seems like a very useful refactor to include in my project from the get-go. |
@aabounegm You could use that generator using the PR branch: git clone https://github.com/eclipse-langium/langium.git
cd langium
git fetch origin refs/pull/1520/head:pr/1520
git switch pr/1520
npm install
npm run build
npm run langium:generate
yo ./packages/generator-langium/app/index.js Please note that you need to install npm install --global yo |
@Yokozuna59 yes I realize that, but thanks for providing the commands and saving me the trouble 😁. |
After #954, the setup of the yeoman project has become a bit complicated. Trying to use
@vscode/vsce
to package a vsix file doesn't work natively due to the inclusion of a customvscode
dependency.Splitting the generated yeoman project into web/language/extension would have a lot of benefits and make features such as #1487 easier as well.
The text was updated successfully, but these errors were encountered: