Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated Yeoman #1268

Merged
merged 3 commits into from
Nov 16, 2023
Merged

Updated Yeoman #1268

merged 3 commits into from
Nov 16, 2023

Conversation

emilkrebs
Copy link
Contributor

  • updated yeoman-generator package
  • updated yeoman-test package
  • moved generator-langium to ESM

spoenemann
spoenemann reviewed Nov 6, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There's a compile error:

packages/generator-langium/test/yeoman-generator.test.ts:37:43 - error TS2554: Expected 0 arguments, but got 1.

37                 generator.destinationRoot(targetRoot); // types are wrong, should be string
                                             ~~~~~~~~~~

packages/generator-langium/test/yeoman-generator.test.ts Show resolved Hide resolved
@emilkrebs
Copy link
Contributor Author

emilkrebs commented Nov 6, 2023 •
edited
Loading

The PR which updated the Yeoman Types got merged. Now we just have to wait until they publish a new version.

yeoman/yeoman-api#3

@emilkrebs
Copy link
Contributor Author

Update: The new types are now published on version v1.1.2

https://github.com/yeoman/yeoman-api/releases/tag/%40yeoman%2Ftypes%401.1.2

spoenemann
spoenemann approved these changes Nov 16, 2023
View reviewed changes
Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@spoenemann spoenemann merged commit 02b3c92 into main Nov 16, 2023
3 checks passed
@spoenemann spoenemann deleted the emilkrebs/updateYeoman branch November 16, 2023 13:00
@spoenemann spoenemann added this to the v3.0.0 milestone Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msujew msujew msujew left review comments

@spoenemann spoenemann spoenemann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@emilkrebs @spoenemann @msujew