Delete target folder before generation #180
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
Aug 11, 2021
There was a problem hiding this comment.
Looks good, but I'm thinking whether bad things can happen when we delete a directory without warning.
Idea: check whether the directory contains any items that are not generated by the current CLI run. If there are such items, display them and ask the user whether to delete them.
|
@spoenemann Sure, makes sense. I added a yes/no check beforehand if the generator notices any additional files in the generated directory. For this, I had to make the whole generator async in order to interact with the console input. |
spoenemann
reviewed
Aug 12, 2021
msujew
force-pushed
the
msujew/delete-folder-generate
branch
from
ccf6add
to
f26716e
Compare
spoenemann
reviewed
Sep 1, 2021
msujew
force-pushed
the
msujew/delete-folder-generate
branch
from
f26716e
to
1a372ea
Compare
msujew
force-pushed
the
msujew/delete-folder-generate
branch
from
1a372ea
to
5f3a055
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #167
Simply deletes the
outputfolder before generation, therefore removing any old files.