Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read debug options from environment variables #227

Merged
merged 1 commit into from
Sep 23, 2021
Merged

Conversation

msujew
Copy link
Member

@msujew msujew commented Sep 17, 2021

Closes #215

// --inspect=6009: runs the server in Node's Inspector mode so VS Code can attach to the server for debugging
const debugOptions = { execArgv: ['--nolazy', '--inspect=6009'] };
// --inspect=6009: runs the server in Node's Inspector mode so VS Code can attach to the server for debugging.
// By setting `proces.env.DEBUG_BREAK` to a truthy value, the language server will wait until a debugger is attached.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// By setting `proces.env.DEBUG_BREAK` to a truthy value, the language server will wait until a debugger is attached.
// By setting `process.env.DEBUG_BREAK` to a truthy value, the language server will wait until a debugger is attached.

Copy link
Contributor

@spoenemann spoenemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to merge, apart from the typo (affects both changes).

@msujew msujew force-pushed the msujew/env-debug-options branch from ff575c7 to d799a6c Compare September 23, 2021 11:14
@msujew msujew merged commit 1aa7947 into main Sep 23, 2021
@spoenemann spoenemann added this to the v0.2.0 milestone Sep 23, 2021
@msujew msujew added the extension VS Code extension related issue label Oct 29, 2021
@msujew msujew deleted the msujew/env-debug-options branch November 6, 2021 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
extension VS Code extension related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make LanguageClient debugOptions configurable
2 participants