Fix review findings #1

utest/TestSelfUpdateScenarios.cpp

@@ -411,12 +411,20 @@ namespace {
         EXPECT_EQ(sentMessages, expectedMessages);
     }
 
-    TEST_F(TestSelfUpdateScenarios, downloadFromHTTPFails_endsInFailedState)
+    class TestSelfUpdateScenariosP
+        : public ::testing::WithParamInterface<std::string>
+        , public virtual TestSelfUpdateScenarios
+    {
+    protected:
+        std::string protocol;
+    };
+
+    TEST_P(TestSelfUpdateScenariosP, downloadViaUnsupportedProtocolFails_endsInFailedState)
     {
         expectedStates   = {"Uninitialized", "Connected", "Downloading", "Failed"};
         expectedMessages = {M::SystemVersion, M::Identifying, M::Identified, M::DownloadFailed};
 
-        downloadProtocol = "http";
+        downloadProtocol = GetParam();
 
         sua.init();
         start();
@@ -428,4 +436,12 @@ namespace {
         EXPECT_EQ(sentMessages, expectedMessages);
     }
 
+    INSTANTIATE_TEST_CASE_P(
+        TestSelfUpdateScenariosViaUnsupportedProtocols,
+        TestSelfUpdateScenariosP,
+        ::testing::Values(
+            "ftp", "sftp", "smb", "smbs", "ldap", "ldaps"
+        )
+    );
+
 }