-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Property location and jump to location in mouse over popup #370 #374
Property location and jump to location in mouse over popup #370 #374
Conversation
lemminx-maven/src/main/java/org/eclipse/lemminx/extensions/maven/utils/MarkdownUtils.java
Outdated
Show resolved
Hide resolved
...est/java/org/eclipse/lemminx/extensions/maven/participants/hover/MavenPropertyHoverTest.java
Show resolved
Hide resolved
...est/java/org/eclipse/lemminx/extensions/maven/participants/hover/MavenPropertyHoverTest.java
Outdated
Show resolved
Hide resolved
d996f87
to
7e96b48
Compare
7e96b48
to
14c0259
Compare
Thank you! |
So great! Thanks, I miss this so much 🙂 |
@vrubezhny I forget to say you that you need to use System.lineSeparator when you write markdown instead of hard coding with\n because If I remember it will not work on Windows os on vscode |
I'll add a PR to fix this. @mickaelistria @angelozerr What do you think of "double" line break in hover between the rows? (The line spaces seen in the screenshot are made by double newline chars |
Thanks, and please use System.lineSeparator in the extected result of test. It will work for you and for CI build if you use \n but not for Windows OS |
I don't really care at the moment about it. I'd like to see how this looks in actual hover to take a decision here. |
@mickaelistria Well. It was probably a stupid question... It looks like markdown needs that "double" new line to really add a line break. With having only one new line char the hover looks like the following (everything is placed in one line): |
The location link is added to the hover: