Fix for "java.lang.IllegalStateException: Could not acquire lock(s)" in MavenLemminxWorkspaceReader #426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
vrubezhny
force-pushed
the
fixWorkspaceReader-populateWSRunner
branch
from
4edb4cb to
57c57a9
Compare
vrubezhny
changed the title
…in MavenLemminxWorkspaceReader Change Workspacereader populate thread to not use `ProjectBuilder.build()` API sue to the possibility to be blocked on locking. Also the PR eclipse-lemminx#425 is used as the source of ProjectBuildingRequest locking configuration: ``` request.getUserProperties().setProperty("aether.syncContext.named.factory", "noop"); ``` Thanks to @cstamas.
vrubezhny
force-pushed
the
fixWorkspaceReader-populateWSRunner
branch
from
57c57a9 to
54f289d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Workspacereader populate thread to not use
ProjectBuilder.build()API sue to the possibilityto be blocked on locking.
Also the PR #425 is used as the source of ProjectBuildingRequest locking configuration:
Thanks to @cstamas.