Improve performance with artifact id completion #467
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
improve-perf-artifactid-completion
branch
from
5872090 to
f9a9a23
Compare
Signed-off-by: azerr <azerr@redhat.com>
angelozerr
force-pushed
the
improve-perf-artifactid-completion
branch
from
f9a9a23 to
8cb1e5e
Compare
vrubezhny
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the completion with artifact id. It seems that completion is slow with artifact ids because the lemminx maven returns too many completion items. In my case I have around 4000 completion items which is slow.
The idea of this PR is just to filter the artifactid if it matches one of a character of the computed prefix. The second improvement is to compute just one time the prefix range and not for each completion item.
Here a demo before the PR:
Here a demo after the PR