Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency completion performance #470

Merged
merged 1 commit into from
Jul 28, 2023
Merged

Dependency completion performance #470

merged 1 commit into from
Jul 28, 2023

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Jul 28, 2023 •
edited
Loading

When you open a pom.xml and you trigger completion inside

<dependencies>
   |

You should see very quickly dependency coming from the XSD, but it doesn't work because:

  • the local aven searcher is initialized at this step and takes some time
  • or the parse of ModelProject throws a CancellableException which stop the completion process

@angelozerr angelozerr requested a review from vrubezhny July 28, 2023 16:49
@angelozerr
Dependency completion performance
d8136c8 
Signed-off-by: azerr <azerr@redhat.com>
@angelozerr angelozerr force-pushed the dependency-completion-perf branch from 40f2d25 to d8136c8 Compare July 28, 2023 21:42
@angelozerr angelozerr marked this pull request as ready for review July 28, 2023 22:01
vrubezhny
vrubezhny approved these changes Jul 28, 2023
View reviewed changes
Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR looks good! Thanks!

@vrubezhny vrubezhny merged commit 431b6ba into eclipse-lemminx:master Jul 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrubezhny vrubezhny vrubezhny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@angelozerr @vrubezhny