Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maven repository is polluted with not existing dependencies #497

Merged

Conversation

angelozerr
Copy link
Contributor

@angelozerr angelozerr commented Aug 7, 2023

Maven repository is polluted with not existing dependencies

Fixes #213

Take a sample with the user local repository ${userName}/.m2/repository

This PR fixes #213 by:

  • setting the local repository of maven request to a dir different from the local user repository ${userName}/.m2/.lemminx-maven. This local repository will contains all metadata files downaloded by aether when artifacts dependencies occurs.
  • register the user local repository ${userName}/.m2/repository as a second local repository (with the property maven.repo.local.tail) to use it to find artifacts. This folder will never polluated with the aether metadata files when user is typing in the editor.

@angelozerr angelozerr force-pushed the dont_polluate_local_repo branch 8 times, most recently from 3e10d38 to bfad237 Compare August 7, 2023 23:12
Copy link
Contributor

@vrubezhny vrubezhny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor change

@Madjosz
Copy link

Madjosz commented Sep 25, 2023

Please adjust your formatter to only format actually changed lines. The commits contain much clutter where nothing relevant has changed but only some whitespace or linefeeds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Maven repository is polluted with not existing dependencies
3 participants