[Request] Completion

[angelozerr]

No description provided.

[NikolasKomonen]

Need to check if the current editor supports snippets at eg: item.setInsertTextFormat(InsertTextFormat.Snippet)

[angelozerr]

@NikolasKomonen I have started to write more test for completion and clean compeltion participant API (not finished). To tests that I have created the JUNit https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/services/HTMLCompletionExtensionsTest.java which has the same test than vscode html language service. To test HTML tags, I have created HTMLPluginCompletion which supports HTML tags (for test).

In other words, HTMLCompletionExtensionsTest provides:

• test for extension completion participant
• have the same test than vscode html language service.

There were a lot of bugs that I have fixed since now I have the same test than vscode html language service (bugs with range). The bad news is that I have disabled your feature https://github.com/angelozerr/lsp4xml/blob/master/org.eclipse.lsp4xml/src/test/java/org/eclipse/lsp4xml/services/XMLCompletionTest.java#L62 because I'm not sure it's a good idea to provide too many XML elements completion. For instance you test with hello causes problem with XML Schema (you can have an hello element but not in a child of hello).

If you are not OK with me, please create a new issue to have this feature. For the moment I would like to clean the API and have the same tests than vscode html language service to be sure that completion works well.

Hope you will understand my choice. But as I say you, I'm totally aware to re-enablz it, if you think it's important. Siorry it's my fault when I review your code, I have not seen this case.