Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preference to enable/disable validation #260

Closed
dhuebner opened this issue Dec 6, 2018 · 4 comments
Closed

Add preference to enable/disable validation #260

dhuebner opened this issue Dec 6, 2018 · 4 comments
Labels
enhancement New feature or request
Milestone

Comments

@dhuebner
Copy link
Contributor

dhuebner commented Dec 6, 2018

It would be nice to have a possibility to disable XML validation

@fbricon fbricon added the enhancement New feature or request label Dec 6, 2018
@fbricon
Copy link
Contributor

fbricon commented Dec 6, 2018

You mean schema validation or also want to skip well-formedness checks?

@dhuebner
Copy link
Contributor Author

dhuebner commented Dec 6, 2018

@fbricon The best would be to have both. At the moment, the most important is schema validation

@angelozerr
Copy link
Contributor

@dhuebner I'm aware to add an enableValidation preferences, but before I would like to understand why you need that?

@dhuebner
Copy link
Contributor Author

dhuebner commented Dec 7, 2018

@angelozerr Just my experience :)
There could be false positives or bugs in validation or you just expect a malformed xml (test cases).
E.g. if I run xml validator in eclipse for the org.eclipse.lsp4xml project it reports me over 120k errors

bildschirmfoto 2018-12-07 um 11 02 31

NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 23, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 23, 2019
@NikolasKomonen NikolasKomonen added this to the v0.0.3 milestone Jan 23, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 24, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 25, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 25, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 25, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 25, 2019
NikolasKomonen pushed a commit to NikolasKomonen/lsp4xml that referenced this issue Jan 28, 2019
fbricon pushed a commit that referenced this issue Jan 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants