Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prolog completion of encoding tag leads to "No more pseudo attributes are allowed" #573

Closed
fbricon opened this issue Oct 15, 2019 · 1 comment · Fixed by #587 or enxio/lsp4xml#9
Closed

Prolog completion of encoding tag leads to "No more pseudo attributes are allowed" #573

fbricon opened this issue Oct 15, 2019 · 1 comment · Fixed by #587 or enxio/lsp4xml#9
Assignees
@NikolasKomonen
Labels
bug Something isn't working
Milestone
v0.9.2

Comments

@fbricon
Copy link
Contributor

fbricon commented Oct 15, 2019 

<?xml version="1.0" standalone="no" encoding="UTF-8"  ?>
<foo>bar</foo>

yields:

Screen Shot 2019-10-15 at 6 29 01 PM
@fbricon
Copy link
Contributor Author

fbricon commented Oct 15, 2019

So the encoding tag can not be after the standalone one. Yet the completion proposes it

@fbricon fbricon added the bug Something isn't working label Oct 15, 2019
@fbricon fbricon changed the title New "No more pseudo attributes are allowed" in prolog Prolog completion of encoding tag leads to "No more pseudo attributes are allowed" Oct 15, 2019
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Oct 28, 2019
@NikolasKomonen
Prolog now completion only provides valid attributes
2ad2e78 
Minor fix to NoMorePseudoAttributes error range.

Fixes eclipse-lemminx#573

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@NikolasKomonen NikolasKomonen mentioned this issue Oct 28, 2019
Merged
NikolasKomonen added a commit to NikolasKomonen/lsp4xml that referenced this issue Nov 1, 2019
@NikolasKomonen
Prolog now completion only provides valid attributes
5d0c2d9 
Minor fix to NoMorePseudoAttributes error range.

Fixes eclipse-lemminx#573

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
angelozerr pushed a commit that referenced this issue Nov 6, 2019
@NikolasKomonen @angelozerr
Prolog now completion only provides valid attributes
082780c 
Minor fix to NoMorePseudoAttributes error range.

Fixes #573

Signed-off-by: Nikolas Komonen <nikolaskomonen@gmail.com>
@enxio enxio mentioned this issue Nov 7, 2019
Merged
@angelozerr angelozerr added this to the v0.9.2 milestone Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NikolasKomonen NikolasKomonen

Labels
bug Something isn't working
Projects
None yet
Milestone
v0.9.2
3 participants
@fbricon @angelozerr @NikolasKomonen