-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide Document Lifecycle Participant for tracking didOpen, did* #1091
Merged
angelozerr
merged 1 commit into
eclipse-lemminx:master
from
angelozerr:document-lifecycle
Jul 30, 2021
Merged
Provide Document Lifecycle Participant for tracking didOpen, did* #1091
angelozerr
merged 1 commit into
eclipse-lemminx:master
from
angelozerr:document-lifecycle
Jul 30, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelozerr
force-pushed
the
document-lifecycle
branch
4 times, most recently
from
July 29, 2021 08:57
0688731
to
76b1f0a
Compare
datho7561
requested changes
Jul 29, 2021
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/XMLTextDocumentService.java
Show resolved
Hide resolved
...inx/src/main/java/org/eclipse/lemminx/services/extensions/IDocumentLifecycleParticipant.java
Outdated
Show resolved
Hide resolved
...inx/src/main/java/org/eclipse/lemminx/services/extensions/IDocumentLifecycleParticipant.java
Outdated
Show resolved
Hide resolved
...pse.lemminx/src/main/java/org/eclipse/lemminx/services/extensions/XMLExtensionsRegistry.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/eclipse/lemminx/services/extensions/DocumentLifecycleParticipantTest.java
Outdated
Show resolved
Hide resolved
.../src/test/java/org/eclipse/lemminx/services/extensions/DocumentLifecycleParticipantTest.java
Show resolved
Hide resolved
angelozerr
force-pushed
the
document-lifecycle
branch
3 times, most recently
from
July 29, 2021 16:01
86293a8
to
99d860f
Compare
datho7561
reviewed
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
datho7561
approved these changes
Jul 29, 2021
rgrunber
reviewed
Jul 29, 2021
...inx/src/main/java/org/eclipse/lemminx/services/extensions/IDocumentLifecycleParticipant.java
Outdated
Show resolved
Hide resolved
rgrunber
reviewed
Jul 29, 2021
...inx/src/main/java/org/eclipse/lemminx/services/extensions/IDocumentLifecycleParticipant.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
document-lifecycle
branch
2 times, most recently
from
July 30, 2021 08:32
8d6aa28
to
508db6d
Compare
Fixes eclipse-lemminx#603 Signed-off-by: azerr <azerr@redhat.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide Document Lifecycle Participant for tracking didOpen, did*
Fixes #603
Signed-off-by: azerr azerr@redhat.com